From 55f298c3a371fc7c04fda5d120a601cda68c140d Mon Sep 17 00:00:00 2001 From: eric_tian Date: Tue, 16 Sep 2008 05:22:09 +0000 Subject: follow up the comments from code review. git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5892 6f19259b-4bc3-4df7-8a09-765794883524 --- MdePkg/Library/IfrSupportLib/UefiIfrForm.c | 44 +++++++++++++++--------------- 1 file changed, 22 insertions(+), 22 deletions(-) (limited to 'MdePkg/Library/IfrSupportLib') diff --git a/MdePkg/Library/IfrSupportLib/UefiIfrForm.c b/MdePkg/Library/IfrSupportLib/UefiIfrForm.c index 3ae15f4161..2f31ed2c73 100644 --- a/MdePkg/Library/IfrSupportLib/UefiIfrForm.c +++ b/MdePkg/Library/IfrSupportLib/UefiIfrForm.c @@ -18,15 +18,15 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. STATIC CONST EFI_FORM_BROWSER2_PROTOCOL *mFormBrowser2 = NULL; STATIC CONST EFI_HII_CONFIG_ROUTING_PROTOCOL *mHiiConfigRouting = NULL; -/** - This function locate FormBrowser2 protocols for later usage. - - @return Status the status to locate protocol. -**/ -EFI_STATUS -LocateFormBrowser2Protocols ( - VOID - ) +/** + This function locate FormBrowser2 protocols for later usage. + + @return Status the status to locate protocol. +**/ +EFI_STATUS +LocateFormBrowser2Protocols ( + VOID + ) { EFI_STATUS Status; // @@ -566,7 +566,7 @@ EFIAPI ConstructConfigHdr ( IN OUT CHAR16 *ConfigHdr, IN OUT UINTN *StrBufferLen, - IN EFI_GUID *Guid, + IN CONST EFI_GUID *Guid, IN CHAR16 *Name, OPTIONAL IN EFI_HANDLE *DriverHandle ) @@ -657,8 +657,8 @@ BOOLEAN EFIAPI FindBlockName ( IN OUT CHAR16 *String, - UINTN Offset, - UINTN Width + IN UINTN Offset, + IN UINTN Width ) { EFI_STATUS Status; @@ -727,10 +727,10 @@ FindBlockName ( EFI_STATUS EFIAPI GetBrowserData ( - EFI_GUID *VariableGuid, OPTIONAL - CHAR16 *VariableName, OPTIONAL - UINTN *BufferSize, - UINT8 *Buffer + IN CONST EFI_GUID *VariableGuid, OPTIONAL + IN CONST CHAR16 *VariableName, OPTIONAL + IN OUT UINTN *BufferSize, + IN OUT UINT8 *Buffer ) { EFI_STATUS Status; @@ -844,11 +844,11 @@ GetBrowserData ( EFI_STATUS EFIAPI SetBrowserData ( - EFI_GUID *VariableGuid, OPTIONAL - CHAR16 *VariableName, OPTIONAL - UINTN BufferSize, - UINT8 *Buffer, - CHAR16 *RequestElement OPTIONAL + IN CONST EFI_GUID *VariableGuid, OPTIONAL + IN CONST CHAR16 *VariableName, OPTIONAL + IN UINTN BufferSize, + IN CONST UINT8 *Buffer, + IN CONST CHAR16 *RequestElement OPTIONAL ) { EFI_STATUS Status; @@ -860,7 +860,7 @@ SetBrowserData ( CHAR16 *Progress; CHAR16 BlockName[33]; CHAR16 *ConfigRequest; - CHAR16 *Request; + CONST CHAR16 *Request; // // Locate protocols for use -- cgit v1.2.3