From d3e0289ccf641481f2cbdcbb0d5868c393b7edbb Mon Sep 17 00:00:00 2001 From: jcarsey Date: Tue, 28 Jun 2011 15:01:53 +0000 Subject: Clarify the requirements for the Destination parameter of UnicodeStrToAsciiStr. signed-off-by:jcarsey Reviewed-by:lgao4 git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11917 6f19259b-4bc3-4df7-8a09-765794883524 --- MdePkg/Include/Library/BaseLib.h | 3 +++ MdePkg/Library/BaseLib/String.c | 5 ++++- 2 files changed, 7 insertions(+), 1 deletion(-) (limited to 'MdePkg') diff --git a/MdePkg/Include/Library/BaseLib.h b/MdePkg/Include/Library/BaseLib.h index c74ea23a74..6998171bd5 100644 --- a/MdePkg/Include/Library/BaseLib.h +++ b/MdePkg/Include/Library/BaseLib.h @@ -636,6 +636,9 @@ StrHexToUint64 ( to the ASCII string Destination by copying the lower 8 bits of each Unicode character. It returns Destination. + The caller is responsible to make sure Destination points to a buffer with size + equal or greater than ((StrLen (Source) + 1) * sizeof (CHAR8)) in bytes. + If any Unicode characters in Source contain non-zero value in the upper 8 bits, then ASSERT(). diff --git a/MdePkg/Library/BaseLib/String.c b/MdePkg/Library/BaseLib/String.c index 273291a915..227a0dc846 100644 --- a/MdePkg/Library/BaseLib/String.c +++ b/MdePkg/Library/BaseLib/String.c @@ -1,7 +1,7 @@ /** @file Unicode and ASCII string primatives. - Copyright (c) 2006 - 2010, Intel Corporation. All rights reserved.
+ Copyright (c) 2006 - 2011, Intel Corporation. All rights reserved.
This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -995,6 +995,9 @@ InternalAsciiIsHexaDecimalDigitCharacter ( to the ASCII string Destination by copying the lower 8 bits of each Unicode character. It returns Destination. + The caller is responsible to make sure Destination points to a buffer with size + equal or greater than ((StrLen (Source) + 1) * sizeof (CHAR8)) in bytes. + If any Unicode characters in Source contain non-zero value in the upper 8 bits, then ASSERT(). -- cgit v1.2.3