From c9c28f38b1f8fc9cde33e63f212776762be99475 Mon Sep 17 00:00:00 2001 From: Laszlo Ersek Date: Wed, 6 Jan 2016 12:34:46 +0000 Subject: NetworkPkg: DnsDxe: fix return type of DnsFillinQNameForQueryIp() Change the return type of DnsFillinQNameForQueryIp() from (UINT8*) to (CHAR*). This brings the function in sync with both its internal variables and all of its call sites, fixing the following gcc build breakage: > NetworkPkg/DnsDxe/DnsImpl.c: In function 'DnsFillinQNameForQueryIp': > NetworkPkg/DnsDxe/DnsImpl.c:1068:3: error: pointer targets in return > differ in signedness > [-Werror=pointer-sign] > return QueryName; > ^ The code was added in git commit fcae1a99 (SVN r19579). Cc: Subramanian Sriram Cc: El-Haj-Mahmoud Samer Cc: Ye Ting Cc: Fu Siyuan Cc: Jiaxin Wu Cc: Ye Ting Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek Reviewed-by: Jiaxin Wu Reviewed-by: Fu Siyuan git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@19609 6f19259b-4bc3-4df7-8a09-765794883524 --- NetworkPkg/DnsDxe/DnsImpl.c | 2 +- NetworkPkg/DnsDxe/DnsImpl.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'NetworkPkg/DnsDxe') diff --git a/NetworkPkg/DnsDxe/DnsImpl.c b/NetworkPkg/DnsDxe/DnsImpl.c index 823bcf3792..71daccea80 100644 --- a/NetworkPkg/DnsDxe/DnsImpl.c +++ b/NetworkPkg/DnsDxe/DnsImpl.c @@ -1026,7 +1026,7 @@ AddDns6ServerIp ( @return QName filled successfully. **/ -UINT8 * +CHAR8 * EFIAPI DnsFillinQNameForQueryIp ( IN CHAR16 *HostName diff --git a/NetworkPkg/DnsDxe/DnsImpl.h b/NetworkPkg/DnsDxe/DnsImpl.h index a13355f855..847cd15973 100644 --- a/NetworkPkg/DnsDxe/DnsImpl.h +++ b/NetworkPkg/DnsDxe/DnsImpl.h @@ -581,7 +581,7 @@ AddDns6ServerIp ( @return QName filled successfully. **/ -UINT8 * +CHAR8 * EFIAPI DnsFillinQNameForQueryIp ( IN CHAR16 *HostName -- cgit v1.2.3