From 07d3ba07709d8aa417f5f887b84ec78a908c6d2a Mon Sep 17 00:00:00 2001 From: Laszlo Ersek Date: Mon, 9 May 2016 20:05:18 +0200 Subject: OvmfPkg: add and use industry standard macro PIIX4_PMBA_MASK We already have the identical purpose (but different value) macro for ICH9, namely ICH9_PMBASE_MASK in "OvmfPkg/Include/IndustryStandard/Q35MchIch9.h". Also, stop bit-negating signed integer constants. Cc: Gabriel Somlo Cc: Jordan Justen Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1333238 Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek Reviewed-by: Jordan Justen Tested-by: Gabriel Somlo --- OvmfPkg/Library/AcpiTimerLib/BaseAcpiTimerLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'OvmfPkg/Library/AcpiTimerLib/BaseAcpiTimerLib.c') diff --git a/OvmfPkg/Library/AcpiTimerLib/BaseAcpiTimerLib.c b/OvmfPkg/Library/AcpiTimerLib/BaseAcpiTimerLib.c index 109b267cf4..652545d864 100644 --- a/OvmfPkg/Library/AcpiTimerLib/BaseAcpiTimerLib.c +++ b/OvmfPkg/Library/AcpiTimerLib/BaseAcpiTimerLib.c @@ -70,7 +70,7 @@ AcpiTimerLibConstructor ( // If the Power Management Base Address is not programmed, // then program it now. // - PciAndThenOr32 (Pmba, (UINT32) ~0xFFC0, PIIX4_PMBA_VALUE); + PciAndThenOr32 (Pmba, ~(UINT32)PIIX4_PMBA_MASK, PIIX4_PMBA_VALUE); // // Enable PMBA I/O port decodes -- cgit v1.2.3