From 24115e44926b33c763f81026690f20efd913daf2 Mon Sep 17 00:00:00 2001 From: ydong10 Date: Fri, 17 Sep 2010 10:42:10 +0000 Subject: RefRefine soma code to make code run safely. git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10885 6f19259b-4bc3-4df7-8a09-765794883524 --- PcAtChipsetPkg/8254TimerDxe/Timer.c | 10 +++++----- PcAtChipsetPkg/8254TimerDxe/Timer.h | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) (limited to 'PcAtChipsetPkg/8254TimerDxe') diff --git a/PcAtChipsetPkg/8254TimerDxe/Timer.c b/PcAtChipsetPkg/8254TimerDxe/Timer.c index b57ccda727..da7d6af578 100644 --- a/PcAtChipsetPkg/8254TimerDxe/Timer.c +++ b/PcAtChipsetPkg/8254TimerDxe/Timer.c @@ -69,7 +69,7 @@ SetPitCount ( } /** - 8254 Timer #0 Interrupt Handler + 8254 Timer #0 Interrupt Handler. @param InterruptType The type of interrupt that occured @param SystemContext A pointer to the system context when the interrupt occured @@ -87,9 +87,9 @@ TimerInterruptHandler ( mLegacy8259->EndOfInterrupt (mLegacy8259, Efi8259Irq0); - if (mTimerNotifyFunction) { + if (mTimerNotifyFunction != NULL) { // - // BUGBUG : This does not handle missed timer interrupts + // @bug : This does not handle missed timer interrupts // mTimerNotifyFunction (mTimerPeriod); } @@ -311,9 +311,9 @@ TimerDriverGenerateSoftInterrupt ( // OriginalTPL = gBS->RaiseTPL (TPL_HIGH_LEVEL); - if (mTimerNotifyFunction) { + if (mTimerNotifyFunction != NULL) { // - // BUGBUG : This does not handle missed timer interrupts + // @bug : This does not handle missed timer interrupts // mTimerNotifyFunction (mTimerPeriod); } diff --git a/PcAtChipsetPkg/8254TimerDxe/Timer.h b/PcAtChipsetPkg/8254TimerDxe/Timer.h index 53de04fb7e..26935d8775 100644 --- a/PcAtChipsetPkg/8254TimerDxe/Timer.h +++ b/PcAtChipsetPkg/8254TimerDxe/Timer.h @@ -78,7 +78,7 @@ TimerDriverInitialize ( @param This The EFI_TIMER_ARCH_PROTOCOL instance. - @param TimerPeriod The rate to program the timer interrupt in 100 nS units. If + @param NotifyFunction The rate to program the timer interrupt in 100 nS units. If the timer hardware is not programmable, then EFI_UNSUPPORTED is returned. If the timer is programmable, then the timer period will be rounded up to the nearest timer period that is supported -- cgit v1.2.3