From 3f869579a47a0c48119e256a5309526f41092812 Mon Sep 17 00:00:00 2001 From: jcarsey Date: Tue, 13 Nov 2012 16:08:52 +0000 Subject: ShellPkg: Correct 3 places where memory was not being properly released by the shell. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jaben Carsey Reviewed-by: Erik Bjorge Reviewed-by: Liu, Jiang A git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13938 6f19259b-4bc3-4df7-8a09-765794883524 --- ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) (limited to 'ShellPkg/Library') diff --git a/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c b/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c index 971294ffd4..fb44768c0b 100644 --- a/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c +++ b/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c @@ -129,7 +129,7 @@ ShellCommandLibDestructor ( ) { SHELL_COMMAND_INTERNAL_LIST_ENTRY *Node; - COMMAND_LIST *Node2; + ALIAS_LIST *Node2; SCRIPT_FILE_LIST *Node3; SHELL_MAP_LIST *MapNode; // @@ -144,13 +144,14 @@ ShellCommandLibDestructor ( } // - // enumerate through the init command list and free all memory + // enumerate through the alias list and free all memory // while (!IsListEmpty (&mAliasList.Link)) { - Node2 = (COMMAND_LIST *)GetFirstNode(&mAliasList.Link); + Node2 = (ALIAS_LIST *)GetFirstNode(&mAliasList.Link); RemoveEntryList(&Node2->Link); SHELL_FREE_NON_NULL(Node2->CommandString); - FreePool(Node2); + SHELL_FREE_NON_NULL(Node2->Alias); + SHELL_FREE_NON_NULL(Node2); DEBUG_CODE(Node2 = NULL;); } -- cgit v1.2.3