From 09bd67f09573ad5a40875f3d7bfbf49c43756cf5 Mon Sep 17 00:00:00 2001 From: Laszlo Ersek Date: Tue, 18 Oct 2016 12:53:48 +0200 Subject: ShellPkg/Shell: fix CopyGuid() arg order in EfiShellGetGuidFromName() The destination GUID comes first; from "MdePkg/Include/Library/BaseMemoryLib.h": > GUID * > EFIAPI > CopyGuid ( > OUT GUID *DestinationGuid, > IN CONST GUID *SourceGuid > ); Here "NewGuid" is the GUID looked up by GetGuidFromStringName(), and "Guid" is where EfiShellGetGuidFromName() has to propagate that result to. Cc: Jaben Carsey Cc: Ruiyu Ni Cc: Tim Lewis Reported-by: Tim Lewis Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek Reviewed-by: Tim Lewis Reviewed-by: Jaben Carsey --- ShellPkg/Application/Shell/ShellProtocol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'ShellPkg') diff --git a/ShellPkg/Application/Shell/ShellProtocol.c b/ShellPkg/Application/Shell/ShellProtocol.c index 2bc0646b45..04b66c5aca 100644 --- a/ShellPkg/Application/Shell/ShellProtocol.c +++ b/ShellPkg/Application/Shell/ShellProtocol.c @@ -2207,7 +2207,7 @@ EfiShellGetGuidFromName( Status = GetGuidFromStringName(GuidName, NULL, &NewGuid); if (!EFI_ERROR(Status)) { - CopyGuid(NewGuid, Guid); + CopyGuid(Guid, NewGuid); } return (Status); -- cgit v1.2.3