From 8cce3c9a70b6406542ca3dac4223cdf5af4f7779 Mon Sep 17 00:00:00 2001
From: Jeff Fan <jeff.fan@intel.com>
Date: Fri, 19 Aug 2016 10:32:30 +0800
Subject: UefiCpuPkg/MpInitLib: MicrocodeData used but maybe uninitialized

Cc: Feng Tian <feng.tian@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jeff Fan <jeff.fan@intel.com>
Reviewed-by: Feng Tian <feng.tian@intel.com>
---
 UefiCpuPkg/Library/MpInitLib/Microcode.c | 2 ++
 1 file changed, 2 insertions(+)

(limited to 'UefiCpuPkg')

diff --git a/UefiCpuPkg/Library/MpInitLib/Microcode.c b/UefiCpuPkg/Library/MpInitLib/Microcode.c
index 0fd8e8c51b..5bb0145c87 100644
--- a/UefiCpuPkg/Library/MpInitLib/Microcode.c
+++ b/UefiCpuPkg/Library/MpInitLib/Microcode.c
@@ -92,6 +92,7 @@ MicrocodeDetect (
   PlatformId = (UINT8) PlatformIdMsr.Bits.PlatformId;
 
   LatestRevision = 0;
+  MicrocodeData  = NULL;
   MicrocodeEnd = (UINTN) (MicrocodePatchAddress + MicrocodePatchRegionSize);
   MicrocodeEntryPoint = (CPU_MICROCODE_HEADER *) (UINTN) MicrocodePatchAddress;
   do {
@@ -198,6 +199,7 @@ MicrocodeDetect (
     // Revision. A processor with no loaded update is considered to have a
     // revision equal to zero.
     //
+    ASSERT (MicrocodeData != NULL);
     AsmWriteMsr64 (
         MSR_IA32_BIOS_UPDT_TRIG,
         (UINT64) (UINTN) MicrocodeData
-- 
cgit v1.2.3