diff options
author | Giacomo Travaglini <giacomo.travaglini@arm.com> | 2018-06-04 09:40:19 +0100 |
---|---|---|
committer | Giacomo Travaglini <giacomo.travaglini@arm.com> | 2018-06-11 16:55:30 +0000 |
commit | f54020eb8155371725ab75b0fc5c419287eca084 (patch) | |
tree | 65d379f7603e689e083e9a58ff4c2e90abd19fbf /src/mem/port_proxy.cc | |
parent | 2113b21996d086dab32b9fd388efe3df241bfbd2 (diff) | |
download | gem5-f54020eb8155371725ab75b0fc5c419287eca084.tar.xz |
misc: Using smart pointers for memory Requests
This patch is changing the underlying type for RequestPtr from Request*
to shared_ptr<Request>. Having memory requests being managed by smart
pointers will simplify the code; it will also prevent memory leakage and
dangling pointers.
Change-Id: I7749af38a11ac8eb4d53d8df1252951e0890fde3
Signed-off-by: Giacomo Travaglini <giacomo.travaglini@arm.com>
Reviewed-by: Andreas Sandberg <andreas.sandberg@arm.com>
Reviewed-on: https://gem5-review.googlesource.com/10996
Reviewed-by: Nikos Nikoleris <nikos.nikoleris@arm.com>
Maintainer: Nikos Nikoleris <nikos.nikoleris@arm.com>
Diffstat (limited to 'src/mem/port_proxy.cc')
-rw-r--r-- | src/mem/port_proxy.cc | 14 |
1 files changed, 10 insertions, 4 deletions
diff --git a/src/mem/port_proxy.cc b/src/mem/port_proxy.cc index d454ef78d..a36e66a99 100644 --- a/src/mem/port_proxy.cc +++ b/src/mem/port_proxy.cc @@ -47,8 +47,11 @@ PortProxy::readBlobPhys(Addr addr, Request::Flags flags, { for (ChunkGenerator gen(addr, size, _cacheLineSize); !gen.done(); gen.next()) { - Request req(gen.addr(), gen.size(), flags, Request::funcMasterId); - Packet pkt(&req, MemCmd::ReadReq); + + auto req = std::make_shared<Request>( + gen.addr(), gen.size(), flags, Request::funcMasterId); + + Packet pkt(req, MemCmd::ReadReq); pkt.dataStatic(p); _port.sendFunctional(&pkt); p += gen.size(); @@ -61,8 +64,11 @@ PortProxy::writeBlobPhys(Addr addr, Request::Flags flags, { for (ChunkGenerator gen(addr, size, _cacheLineSize); !gen.done(); gen.next()) { - Request req(gen.addr(), gen.size(), flags, Request::funcMasterId); - Packet pkt(&req, MemCmd::WriteReq); + + auto req = std::make_shared<Request>( + gen.addr(), gen.size(), flags, Request::funcMasterId); + + Packet pkt(req, MemCmd::WriteReq); pkt.dataStaticConst(p); _port.sendFunctional(&pkt); p += gen.size(); |