From 006818aeea6176c4500c5f7414e9f2a822c77062 Mon Sep 17 00:00:00 2001 From: Nathan Binkert Date: Thu, 10 Jun 2010 23:17:07 -0700 Subject: ruby: get rid of Vector and use STL add a couple of helper functions to base for deleteing all pointers in a container and outputting containers to a stream --- src/base/stl_helpers.hh | 97 ++++++ src/cpu/rubytest/CheckTable.cc | 2 +- src/cpu/rubytest/CheckTable.hh | 4 +- src/cpu/rubytest/RubyTester.cc | 2 +- src/cpu/rubytest/RubyTester.hh | 3 +- src/mem/gems_common/Map.hh | 33 +- src/mem/gems_common/PrioHeap.hh | 10 +- src/mem/gems_common/Vector.hh | 337 --------------------- src/mem/ruby/buffers/MessageBuffer.hh | 2 +- src/mem/ruby/common/DataBlock.hh | 1 - src/mem/ruby/common/Histogram.cc | 2 +- src/mem/ruby/common/Histogram.hh | 4 +- src/mem/ruby/common/NetDest.cc | 12 +- src/mem/ruby/common/NetDest.hh | 8 +- src/mem/ruby/common/SubBlock.cc | 5 +- src/mem/ruby/common/SubBlock.hh | 6 +- src/mem/ruby/eventqueue/RubyEventQueue.hh | 1 - src/mem/ruby/filters/BlockBloomFilter.cc | 2 +- src/mem/ruby/filters/BlockBloomFilter.hh | 4 +- src/mem/ruby/filters/BulkBloomFilter.cc | 4 +- src/mem/ruby/filters/BulkBloomFilter.hh | 6 +- src/mem/ruby/filters/H3BloomFilter.cc | 2 +- src/mem/ruby/filters/H3BloomFilter.hh | 4 +- src/mem/ruby/filters/LSB_CountingBloomFilter.cc | 2 +- src/mem/ruby/filters/LSB_CountingBloomFilter.hh | 4 +- src/mem/ruby/filters/MultiBitSelBloomFilter.cc | 2 +- src/mem/ruby/filters/MultiBitSelBloomFilter.hh | 4 +- src/mem/ruby/filters/MultiGrainBloomFilter.cc | 4 +- src/mem/ruby/filters/MultiGrainBloomFilter.hh | 6 +- src/mem/ruby/filters/NonCountingBloomFilter.cc | 2 +- src/mem/ruby/filters/NonCountingBloomFilter.hh | 4 +- src/mem/ruby/network/Network.cc | 2 +- src/mem/ruby/network/Network.hh | 3 +- .../garnet/fixed-pipeline/GarnetNetwork_d.cc | 48 +-- .../garnet/fixed-pipeline/GarnetNetwork_d.hh | 18 +- .../network/garnet/fixed-pipeline/InputUnit_d.cc | 6 +- .../network/garnet/fixed-pipeline/InputUnit_d.hh | 4 +- .../garnet/fixed-pipeline/NetworkInterface_d.cc | 24 +- .../garnet/fixed-pipeline/NetworkInterface_d.hh | 17 +- .../network/garnet/fixed-pipeline/NetworkLink_d.cc | 6 +- .../network/garnet/fixed-pipeline/NetworkLink_d.hh | 5 +- .../network/garnet/fixed-pipeline/OutputUnit_d.cc | 6 +- .../network/garnet/fixed-pipeline/OutputUnit_d.hh | 3 +- .../ruby/network/garnet/fixed-pipeline/Router_d.cc | 10 +- .../ruby/network/garnet/fixed-pipeline/Router_d.hh | 10 +- .../network/garnet/fixed-pipeline/RoutingUnit_d.cc | 4 +- .../network/garnet/fixed-pipeline/RoutingUnit_d.hh | 4 +- .../network/garnet/fixed-pipeline/SWallocator_d.cc | 12 +- .../network/garnet/fixed-pipeline/SWallocator_d.hh | 13 +- .../ruby/network/garnet/fixed-pipeline/Switch_d.cc | 7 +- .../ruby/network/garnet/fixed-pipeline/Switch_d.hh | 5 +- .../network/garnet/fixed-pipeline/VCallocator_d.cc | 20 +- .../network/garnet/fixed-pipeline/VCallocator_d.hh | 13 +- .../garnet/flexible-pipeline/GarnetNetwork.cc | 40 +-- .../garnet/flexible-pipeline/GarnetNetwork.hh | 16 +- .../garnet/flexible-pipeline/NetworkInterface.cc | 22 +- .../garnet/flexible-pipeline/NetworkInterface.hh | 14 +- .../garnet/flexible-pipeline/NetworkLink.cc | 4 +- .../garnet/flexible-pipeline/NetworkLink.hh | 5 +- .../network/garnet/flexible-pipeline/Router.cc | 50 +-- .../network/garnet/flexible-pipeline/Router.hh | 23 +- src/mem/ruby/network/simple/PerfectSwitch.cc | 26 +- src/mem/ruby/network/simple/PerfectSwitch.hh | 14 +- src/mem/ruby/network/simple/SimpleNetwork.cc | 36 +-- src/mem/ruby/network/simple/SimpleNetwork.hh | 20 +- src/mem/ruby/network/simple/Switch.cc | 35 ++- src/mem/ruby/network/simple/Switch.hh | 12 +- src/mem/ruby/network/simple/Throttle.cc | 14 +- src/mem/ruby/network/simple/Throttle.hh | 16 +- src/mem/ruby/network/simple/Topology.cc | 36 +-- src/mem/ruby/network/simple/Topology.hh | 21 +- src/mem/ruby/profiler/AddressProfiler.cc | 15 +- src/mem/ruby/profiler/CacheProfiler.cc | 15 +- src/mem/ruby/profiler/CacheProfiler.hh | 5 +- src/mem/ruby/profiler/MemCntrlProfiler.cc | 2 +- src/mem/ruby/profiler/MemCntrlProfiler.hh | 6 +- src/mem/ruby/profiler/Profiler.cc | 30 +- src/mem/ruby/profiler/Profiler.hh | 17 +- src/mem/ruby/system/CacheMemory.cc | 10 +- src/mem/ruby/system/CacheMemory.hh | 5 +- src/mem/ruby/system/MemoryVector.hh | 6 +- src/mem/ruby/system/Sequencer.cc | 6 +- src/mem/ruby/system/System.cc | 2 +- src/mem/ruby/system/System.hh | 1 - src/mem/ruby/system/TimerTable.cc | 2 +- src/mem/ruby/tester/DeterministicDriver.cc | 18 +- src/mem/ruby/tester/DeterministicDriver.hh | 19 +- src/mem/ruby/tester/RaceyDriver.cc | 2 +- src/mem/ruby/tester/RaceyDriver.hh | 6 +- src/mem/slicc/symbols/StateMachine.py | 2 +- 90 files changed, 604 insertions(+), 788 deletions(-) create mode 100644 src/base/stl_helpers.hh delete mode 100644 src/mem/gems_common/Vector.hh diff --git a/src/base/stl_helpers.hh b/src/base/stl_helpers.hh new file mode 100644 index 000000000..740bd1b48 --- /dev/null +++ b/src/base/stl_helpers.hh @@ -0,0 +1,97 @@ +/* + * Copyright (c) 2010 The Hewlett-Packard Development Company + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions are + * met: redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer; + * redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in the + * documentation and/or other materials provided with the distribution; + * neither the name of the copyright holders nor the names of its + * contributors may be used to endorse or promote products derived from + * this software without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + * + * Authors: Nathan Binkert + */ + +#ifndef __BASE_STL_HELPERS_HH__ +#define __BASE_STL_HELPERS_HH__ + +#include +#include + +namespace m5 { +namespace stl_helpers { + +template +void +deletePointer(T &ptr) +{ + delete ptr; + ptr = NULL; +} + +template +class ContainerPrint +{ + private: + std::ostream &out; + bool first; + + public: + ContainerPrint(std::ostream &out) + : out(out), first(true) + {} + + void + operator()(const T &elem) + { + out << elem; + // First one doesn't get a space before it. The rest do. + if (first) + first = false; + else + out << " "; + } +}; + +// Treat all objects in an stl container as pointers to heap objects, +// calling delete on each one and zeroing the pointers along the way +template class C, typename A> +void +deletePointers(C &container) +{ + std::for_each(container.begin(), container.end(), deletePointer); +} + +// Write out all elements in an stl container as a space separated +// list enclosed in square brackets +template class C, typename A> +std::ostream & +operator<<(std::ostream& out, const C &vec) +{ + out << "[ "; + std::for_each(vec.begin(), vec.end(), ContainerPrint(out)); + out << " ]"; + out << std::flush; + return out; +} + +/* namespace stl_helpers */ } +/* namespace m5 */ } + +#endif // __BASE_STL_HELPERS_HH__ diff --git a/src/cpu/rubytest/CheckTable.cc b/src/cpu/rubytest/CheckTable.cc index 3b94de315..7588007c9 100644 --- a/src/cpu/rubytest/CheckTable.cc +++ b/src/cpu/rubytest/CheckTable.cc @@ -102,7 +102,7 @@ CheckTable::addCheck(const Address& address) // Insert it once per byte m_lookup_map_ptr->add(Address(address.getAddress() + i), check_ptr); } - m_check_vector.insertAtBottom(check_ptr); + m_check_vector.push_back(check_ptr); } Check* diff --git a/src/cpu/rubytest/CheckTable.hh b/src/cpu/rubytest/CheckTable.hh index a22fa7f73..117fb1276 100644 --- a/src/cpu/rubytest/CheckTable.hh +++ b/src/cpu/rubytest/CheckTable.hh @@ -31,8 +31,8 @@ #define __CPU_RUBYTEST_CHECKTABLE_HH__ #include +#include -#include "mem/gems_common/Vector.hh" #include "mem/ruby/common/Global.hh" class Address; @@ -63,7 +63,7 @@ class CheckTable CheckTable(const CheckTable& obj); CheckTable& operator=(const CheckTable& obj); - Vector m_check_vector; + std::vector m_check_vector; Map* m_lookup_map_ptr; int m_num_cpu_sequencers; diff --git a/src/cpu/rubytest/RubyTester.cc b/src/cpu/rubytest/RubyTester.cc index 3ad977b42..036e511bc 100644 --- a/src/cpu/rubytest/RubyTester.cc +++ b/src/cpu/rubytest/RubyTester.cc @@ -59,7 +59,7 @@ RubyTester::init() { assert(ports.size() > 0); - m_last_progress_vector.setSize(ports.size()); + m_last_progress_vector.resize(ports.size()); for (int i = 0; i < m_last_progress_vector.size(); i++) { m_last_progress_vector[i] = 0; } diff --git a/src/cpu/rubytest/RubyTester.hh b/src/cpu/rubytest/RubyTester.hh index 634e61f88..2726a50d6 100644 --- a/src/cpu/rubytest/RubyTester.hh +++ b/src/cpu/rubytest/RubyTester.hh @@ -31,6 +31,7 @@ #define __CPU_RUBYTEST_RUBYTESTER_HH__ #include +#include #include #include "cpu/rubytest/CheckTable.hh" @@ -126,7 +127,7 @@ class RubyTester : public MemObject RubyTester& operator=(const RubyTester& obj); CheckTable* m_checkTable_ptr; - Vector