From 76c4c5fabc27922639bb5c8549620e4496454efe Mon Sep 17 00:00:00 2001
From: Steve Reinhardt <stever@gmail.com>
Date: Sun, 16 Sep 2007 16:46:38 -0700
Subject: mem: clean up bus/cache DPRINTFs a bit Not so much noise on failed
 sends, and more complete info when grepping a trace using an address.

--HG--
extra : convert_revision : 05a8261c9452072ca08b906200c6322b33e2b9f1
---
 src/mem/bus.cc              | 11 +++++++----
 src/mem/cache/cache_impl.hh | 11 ++++-------
 2 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/src/mem/bus.cc b/src/mem/bus.cc
index 6e790e438..02012ad4c 100644
--- a/src/mem/bus.cc
+++ b/src/mem/bus.cc
@@ -170,8 +170,6 @@ bool
 Bus::recvTiming(PacketPtr pkt)
 {
     short src = pkt->getSrc();
-    DPRINTF(Bus, "recvTiming: packet src %d dest %d addr 0x%x cmd %s\n",
-            src, pkt->getDest(), pkt->getAddr(), pkt->cmdString());
 
     BusPort *src_port;
     if (src == defaultId)
@@ -191,10 +189,14 @@ Bus::recvTiming(PacketPtr pkt)
          (retryList.size() && (!inRetry || src_port != retryList.front()))))
     {
         addToRetryList(src_port);
-        DPRINTF(Bus, "recvTiming: Bus is busy, returning false\n");
+        DPRINTF(Bus, "recvTiming: src %d dst %d %s 0x%x BUSY\n",
+                src, pkt->getDest(), pkt->cmdString(), pkt->getAddr());
         return false;
     }
 
+    DPRINTF(Bus, "recvTiming: src %d dst %d %s 0x%x\n",
+            src, pkt->getDest(), pkt->cmdString(), pkt->getAddr());
+
     if (!pkt->isExpressSnoop()) {
         occupyBus(pkt);
     }
@@ -243,7 +245,8 @@ Bus::recvTiming(PacketPtr pkt)
             // Packet not successfully sent. Leave or put it on the retry list.
             // illegal to block responses... can lead to deadlock
             assert(!pkt->isResponse());
-            DPRINTF(Bus, "Adding2 a retry to RETRY list %d\n", src);
+            DPRINTF(Bus, "recvTiming: src %d dst %d %s 0x%x TGT RETRY\n",
+                    src, pkt->getDest(), pkt->cmdString(), pkt->getAddr());
             addToRetryList(src_port);
             return false;
         }
diff --git a/src/mem/cache/cache_impl.hh b/src/mem/cache/cache_impl.hh
index 34084c8dc..92ff4d12e 100644
--- a/src/mem/cache/cache_impl.hh
+++ b/src/mem/cache/cache_impl.hh
@@ -994,6 +994,10 @@ Cache<TagStore>::handleSnoop(PacketPtr pkt, BlkType *blk,
         blk->status &= ~bits_to_clear;
     }
 
+    DPRINTF(Cache, "snooped a %s request for addr %x, %snew state is %i\n",
+            pkt->cmdString(), blockAlign(pkt->getAddr()),
+            respond ? "responding, " : "", invalidate ? 0 : blk->status);
+
     if (respond) {
         assert(!pkt->memInhibitAsserted());
         pkt->assertMemInhibit();
@@ -1013,10 +1017,6 @@ Cache<TagStore>::handleSnoop(PacketPtr pkt, BlkType *blk,
     if (invalidate) {
         tags->invalidateBlk(blk);
     }
-
-    DPRINTF(Cache, "snooped a %s request for addr %x, %snew state is %i\n",
-            pkt->cmdString(), blockAlign(pkt->getAddr()),
-            respond ? "responding, " : "", blk->status);
 }
 
 
@@ -1384,9 +1384,6 @@ Cache<TagStore>::MemSidePort::sendPacket()
             MSHR *mshr = dynamic_cast<MSHR*>(pkt->senderState);
 
             bool success = sendTiming(pkt);
-            DPRINTF(CachePort,
-                    "Address %x was %s in sending the timing request\n",
-                    pkt->getAddr(), success ? "successful" : "unsuccessful");
 
             waitingOnRetry = !success;
             if (waitingOnRetry) {
-- 
cgit v1.2.3


From ffdd67308a491992c2655935a259c8df7b528798 Mon Sep 17 00:00:00 2001
From: Steve Reinhardt <stever@gmail.com>
Date: Wed, 31 Oct 2007 00:44:51 -0700
Subject: SConstruct: Fix env Dir/String problem

--HG--
extra : convert_revision : 6c5b6e9541030774bc44933f021fec51fb3cb227
---
 SConstruct | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/SConstruct b/SConstruct
index 30c1ed0a6..6c642b5c7 100644
--- a/SConstruct
+++ b/SConstruct
@@ -236,7 +236,7 @@ if False:
     env.TargetSignatures('content')
 
 # M5_PLY is used by isa_parser.py to find the PLY package.
-env.Append(ENV = { 'M5_PLY' : Dir('ext/ply') })
+env.Append(ENV = { 'M5_PLY' : str(Dir('ext/ply')) })
 env['GCC'] = False
 env['SUNCC'] = False
 env['ICC'] = False
@@ -276,7 +276,7 @@ else:
 if sys.platform == 'cygwin':
     # cygwin has some header file issues...
     env.Append(CCFLAGS=Split("-Wno-uninitialized"))
-env.Append(CPPPATH=[Dir('ext/dnet')])
+env.Append(CPPPATH=[str(Dir('ext/dnet'))])
 
 # Check for SWIG
 if not env.has_key('SWIG'):
-- 
cgit v1.2.3


From 514236c3148e0d1640c46c77830ff03de76d29a0 Mon Sep 17 00:00:00 2001
From: Steve Reinhardt <stever@gmail.com>
Date: Wed, 31 Oct 2007 00:55:32 -0700
Subject: SConstruct: undo half of last changeset; looked innocuous but wasn't.

--HG--
extra : convert_revision : 237da629f9e4e8f9151fcf3c47ea2ef72918356a
---
 SConstruct | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/SConstruct b/SConstruct
index 6c642b5c7..9394fa61b 100644
--- a/SConstruct
+++ b/SConstruct
@@ -276,7 +276,7 @@ else:
 if sys.platform == 'cygwin':
     # cygwin has some header file issues...
     env.Append(CCFLAGS=Split("-Wno-uninitialized"))
-env.Append(CPPPATH=[str(Dir('ext/dnet'))])
+env.Append(CPPPATH=[Dir('ext/dnet')])
 
 # Check for SWIG
 if not env.has_key('SWIG'):
-- 
cgit v1.2.3