From 1434b8694319047ba7f35cc6c1a9c965ccba3f22 Mon Sep 17 00:00:00 2001 From: Steve Reinhardt Date: Sat, 21 Jun 2008 01:06:27 -0400 Subject: Make bus address conflict error more informative --- src/mem/bus.cc | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/mem/bus.cc b/src/mem/bus.cc index 9dd3353fd..4468262ac 100644 --- a/src/mem/bus.cc +++ b/src/mem/bus.cc @@ -524,9 +524,12 @@ Bus::recvStatusChange(Port::Status status, int id) for (iter = ranges.begin(); iter != ranges.end(); iter++) { DPRINTF(BusAddrRanges, "Adding range %#llx - %#llx for id %d\n", iter->start, iter->end, id); - if (portMap.insert(*iter, id) == portMap.end()) - panic("Two devices with same range\n"); - + if (portMap.insert(*iter, id) == portMap.end()) { + int conflict_id = portMap.find(*iter)->second; + fatal("%s has two ports with same range:\n\t%s\n\t%s\n", + name(), interfaces[id]->getPeer()->name(), + interfaces[conflict_id]->getPeer()->name()); + } } } DPRINTF(MMU, "port list has %d entries\n", portMap.size()); -- cgit v1.2.3 From 18c83be50702e27ef092a3c7630514b364f60aa0 Mon Sep 17 00:00:00 2001 From: Gabe Black Date: Sat, 21 Jun 2008 14:23:58 -0400 Subject: SimObject: Add in missing includes of and fix minor style problem. --- src/sim/sim_object.hh | 5 +++-- src/sim/sim_object_params.hh | 2 ++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/sim/sim_object.hh b/src/sim/sim_object.hh index ec565ce82..00bb3fee6 100644 --- a/src/sim/sim_object.hh +++ b/src/sim/sim_object.hh @@ -36,10 +36,11 @@ #ifndef __SIM_OBJECT_HH__ #define __SIM_OBJECT_HH__ -#include +#include #include +#include +#include #include -#include #include "params/SimObject.hh" #include "sim/serialize.hh" diff --git a/src/sim/sim_object_params.hh b/src/sim/sim_object_params.hh index 4179a37bf..5a629a949 100644 --- a/src/sim/sim_object_params.hh +++ b/src/sim/sim_object_params.hh @@ -36,6 +36,8 @@ struct PyObject; #endif +#include + struct SimObjectParams { virtual ~SimObjectParams() {} -- cgit v1.2.3 From 57b5de6b9f9150ceda46c52b3621e60f667138d4 Mon Sep 17 00:00:00 2001 From: Ali Saidi Date: Tue, 24 Jun 2008 15:48:45 -0400 Subject: Checkpoinging/SWIG: Undo part of changeset 5464 since it broke checkpointing. --- src/python/swig/event.i | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/python/swig/event.i b/src/python/swig/event.i index ee1f3d00b..9a2093c99 100644 --- a/src/python/swig/event.i +++ b/src/python/swig/event.i @@ -44,8 +44,8 @@ void create(PyObject *object, Tick when); -class CountedDrainEvent -{ +class Event; +class CountedDrainEvent : public Event { public: void setCount(int _count); }; -- cgit v1.2.3