From d8a34a9745d652b6e4484cf227754e7f23e48879 Mon Sep 17 00:00:00 2001 From: Korey Sewell Date: Sat, 18 Apr 2009 10:42:29 -0400 Subject: mips-tlb-fix: check for alignment faults.\nMIPS was never updated to use TLBS correcty in SE mode. The error was forwarding translations directly to pageTable. The TLB should check for alignment faults at bare minimum here but in the long run we should be using TLBs in SE mode for MIPS. --- src/arch/mips/tlb.cc | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/arch/mips/tlb.cc b/src/arch/mips/tlb.cc index 9fc3e20ee..001dc2cb7 100644 --- a/src/arch/mips/tlb.cc +++ b/src/arch/mips/tlb.cc @@ -427,6 +427,18 @@ Fault TLB::translateData(RequestPtr req, ThreadContext *tc, bool write) { #if !FULL_SYSTEM + //@TODO: This should actually use TLB instead of going directly + // to the page table in syscall mode. + /** + * Check for alignment faults + */ + if (req->getVaddr() & (req->getSize() - 1)) { + DPRINTF(TLB, "Alignment Fault on %#x, size = %d", req->getVaddr(), + req->getSize()); + return new AlignmentFault(); + } + + Process * p = tc->getProcessPtr(); Fault fault = p->pTable->translate(req); -- cgit v1.2.3