From c2fcac7c0dd8dff182cb262bdf35d5c67117aa42 Mon Sep 17 00:00:00 2001 From: Kevin Lim Date: Thu, 19 May 2005 01:28:25 -0400 Subject: Fix up code for initial release. The main bug that remains is properly forwarding data from stores to loads, specifically when they are of differing sizes. cpu/base_dyn_inst.cc: Remove unused commented out code. cpu/base_dyn_inst.hh: Fix up comments. cpu/beta_cpu/2bit_local_pred.cc: Reorder code to match header file. cpu/beta_cpu/2bit_local_pred.hh: Update comments. cpu/beta_cpu/alpha_dyn_inst.hh: Remove useless comments. cpu/beta_cpu/alpha_dyn_inst_impl.hh: cpu/beta_cpu/alpha_full_cpu_impl.hh: cpu/beta_cpu/comm.hh: cpu/beta_cpu/iew_impl.hh: Remove unused commented code. cpu/beta_cpu/alpha_full_cpu.hh: Remove obsolete comment. cpu/beta_cpu/alpha_impl.hh: cpu/beta_cpu/full_cpu.hh: Alphabetize includes. cpu/beta_cpu/bpred_unit.hh: Remove unused global history code. cpu/beta_cpu/btb.hh: cpu/beta_cpu/free_list.hh: Use full path in #defines. cpu/beta_cpu/commit.hh: cpu/beta_cpu/decode.hh: Reorder functions. cpu/beta_cpu/commit_impl.hh: Remove obsolete commented code. cpu/beta_cpu/fetch.hh: Remove obsolete comments. cpu/beta_cpu/fetch_impl.hh: cpu/beta_cpu/rename_impl.hh: Remove commented code. cpu/beta_cpu/full_cpu.cc: Remove useless defines. cpu/beta_cpu/inst_queue.hh: Use full path for #defines. cpu/beta_cpu/inst_queue_impl.hh: Reorder functions to match header file. cpu/beta_cpu/mem_dep_unit.hh: Use full path name for #defines. cpu/beta_cpu/ras.hh: Use full path names for #defines. Remove mod operation. cpu/beta_cpu/regfile.hh: Remove unused commented code, fix up current comments. cpu/beta_cpu/tournament_pred.cc: cpu/beta_cpu/tournament_pred.hh: Update programming style. --HG-- extra : convert_revision : fb9d18a853f58a1108ff827e3c123d5b52a0608a --- cpu/beta_cpu/mem_dep_unit.hh | 25 +++++++++++-------------- 1 file changed, 11 insertions(+), 14 deletions(-) (limited to 'cpu/beta_cpu/mem_dep_unit.hh') diff --git a/cpu/beta_cpu/mem_dep_unit.hh b/cpu/beta_cpu/mem_dep_unit.hh index e43543e09..5da57945f 100644 --- a/cpu/beta_cpu/mem_dep_unit.hh +++ b/cpu/beta_cpu/mem_dep_unit.hh @@ -1,12 +1,12 @@ -#ifndef __MEM_DEP_UNIT_HH__ -#define __MEM_DEP_UNIT_HH__ +#ifndef __CPU_BETA_CPU_MEM_DEP_UNIT_HH__ +#define __CPU_BETA_CPU_MEM_DEP_UNIT_HH__ -#include #include +#include -#include "cpu/inst_seq.hh" #include "base/statistics.hh" +#include "cpu/inst_seq.hh" /** * Memory dependency unit class. This holds the memory dependence predictor. @@ -34,6 +34,12 @@ class MemDepUnit { void insertNonSpec(DynInstPtr &inst); + // Will want to make this operation relatively fast. Right now it + // is somewhat slow. + DynInstPtr &top(); + + void pop(); + void regsReady(DynInstPtr &inst); void nonSpecInstReady(DynInstPtr &inst); @@ -46,12 +52,6 @@ class MemDepUnit { void violation(DynInstPtr &store_inst, DynInstPtr &violating_load); - // Will want to make this operation relatively fast. Right now it - // kind of sucks. - DynInstPtr &top(); - - void pop(); - inline bool empty() { return readyInsts.empty(); } @@ -91,11 +91,8 @@ class MemDepUnit { } }; - - private: inline void moveToReady(dep_it_t &woken_inst); - private: /** List of instructions that have passed through rename, yet are still * waiting on either a memory dependence to resolve or source registers to * become available before they can issue. @@ -137,4 +134,4 @@ class MemDepUnit { Stats::Scalar<> conflictingStores; }; -#endif +#endif // __CPU_BETA_CPU_MEM_DEP_UNIT_HH__ -- cgit v1.2.3