From a51565f6ae19206ff8814d2cdfd13b8f5277c6ef Mon Sep 17 00:00:00 2001 From: Nathan Binkert Date: Fri, 21 Oct 2005 19:18:19 -0400 Subject: It's not necessary for a device to call recvDone, that automatically happens in the interface after the packet is delivered to the device. --HG-- extra : convert_revision : 07890c4c5ce83fe709ce203f66c330d7cd631235 --- dev/ns_gige.cc | 4 ---- dev/sinic.cc | 3 --- 2 files changed, 7 deletions(-) (limited to 'dev') diff --git a/dev/ns_gige.cc b/dev/ns_gige.cc index f6d15b02f..7e7fedc15 100644 --- a/dev/ns_gige.cc +++ b/dev/ns_gige.cc @@ -2531,20 +2531,17 @@ NSGigE::recvPacket(PacketPtr packet) if (!rxEnable) { DPRINTF(Ethernet, "receive disabled...packet dropped\n"); - interface->recvDone(); return true; } if (!rxFilterEnable) { DPRINTF(Ethernet, "receive packet filtering disabled . . . packet dropped\n"); - interface->recvDone(); return true; } if (rxFilter(packet)) { DPRINTF(Ethernet, "packet filtered...dropped\n"); - interface->recvDone(); return true; } @@ -2567,7 +2564,6 @@ NSGigE::recvPacket(PacketPtr packet) } rxFifo.push(packet); - interface->recvDone(); rxKick(); return true; diff --git a/dev/sinic.cc b/dev/sinic.cc index 0f2fd20ea..0619a63dd 100644 --- a/dev/sinic.cc +++ b/dev/sinic.cc @@ -1085,13 +1085,11 @@ Device::recvPacket(PacketPtr packet) if (!rxEnable) { DPRINTF(Ethernet, "receive disabled...packet dropped\n"); - interface->recvDone(); return true; } if (rxFilter(packet)) { DPRINTF(Ethernet, "packet filtered...dropped\n"); - interface->recvDone(); return true; } @@ -1104,7 +1102,6 @@ Device::recvPacket(PacketPtr packet) return false; } - interface->recvDone(); devIntrPost(Regs::Intr_RxDone); rxKick(); return true; -- cgit v1.2.3