From ae3d45685512b75f878eb9d7917680fc3971988e Mon Sep 17 00:00:00 2001 From: Ali Saidi Date: Wed, 23 Feb 2011 15:10:49 -0600 Subject: ARM: Fix bug that let two table walks occur in parallel. --- src/arch/arm/table_walker.cc | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) (limited to 'src/arch/arm/table_walker.cc') diff --git a/src/arch/arm/table_walker.cc b/src/arch/arm/table_walker.cc index e6dd728dd..e2207e26b 100644 --- a/src/arch/arm/table_walker.cc +++ b/src/arch/arm/table_walker.cc @@ -141,12 +141,12 @@ TableWalker::walk(RequestPtr _req, ThreadContext *_tc, uint8_t _cid, TLB::Mode _ if (!currState->timing) return processWalk(); - if (pending) { + if (pending || pendingQueue.size()) { pendingQueue.push_back(currState); currState = NULL; } else { pending = true; - processWalk(); + return processWalk(); } return NoFault; @@ -194,10 +194,8 @@ TableWalker::processWalk() f = tlb->walkTrickBoxCheck(l1desc_addr, currState->vaddr, sizeof(uint32_t), currState->isFetch, currState->isWrite, 0, true); if (f) { + DPRINTF(TLB, "Trickbox check caused fault on %#x\n", currState->vaddr); if (currState->timing) { - currState->transState->finish(f, currState->req, - currState->tc, currState->mode); - pending = false; nextWalk(currState->tc); currState = NULL; -- cgit v1.2.3