From 2a15bfd79ced20a6d4cbf0a0a4c2fbb1444b9a44 Mon Sep 17 00:00:00 2001 From: Gabe Black Date: Fri, 5 Jan 2018 15:01:00 -0800 Subject: arch, mem: Make the page table lookup function return a pointer. This avoids having a copy in the lookup function itself, and the declaration of a lot of temporary TLB entry pointers in callers. The gpu TLB seems to have had the most dependence on the original signature of the lookup function, partially because it was relying on a somewhat unsafe copy to a TLB entry using a base class pointer type. Change-Id: I8b1cf494468163deee000002d243541657faf57f Reviewed-on: https://gem5-review.googlesource.com/7343 Reviewed-by: Gabe Black Maintainer: Gabe Black --- src/arch/mips/remote_gdb.cc | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) (limited to 'src/arch/mips') diff --git a/src/arch/mips/remote_gdb.cc b/src/arch/mips/remote_gdb.cc index e17f8fd1d..d490fa518 100644 --- a/src/arch/mips/remote_gdb.cc +++ b/src/arch/mips/remote_gdb.cc @@ -162,13 +162,10 @@ RemoteGDB::RemoteGDB(System *_system, ThreadContext *tc, int _port) bool RemoteGDB::acc(Addr va, size_t len) { - TlbEntry entry; - //Check to make sure the first byte is mapped into the processes address - //space. - if (FullSystem) - panic("acc not implemented for MIPS FS!"); - else - return context()->getProcessPtr()->pTable->lookup(va, entry); + // Check to make sure the first byte is mapped into the processes address + // space. + panic_if(FullSystem, "acc not implemented for MIPS FS!"); + return context()->getProcessPtr()->pTable->lookup(va) != nullptr; } void -- cgit v1.2.3