From e1ac9629398027186ef4c2a66772aeff2b4c6792 Mon Sep 17 00:00:00 2001 From: Andreas Hansson Date: Wed, 3 Sep 2014 07:42:21 -0400 Subject: arch: Cleanup unused ISA traits constants This patch prunes unused values, and also unifies how the values are defined (not using an enum for ALPHA), aligning the use of int vs Addr etc. The patch also removes the duplication of PageBytes/PageShift and VMPageSize/LogVMPageSize. For all ISAs the two pairs had identical values and the latter has been removed. --- src/arch/power/isa_traits.hh | 3 --- src/arch/power/process.cc | 6 +++--- 2 files changed, 3 insertions(+), 6 deletions(-) (limited to 'src/arch/power') diff --git a/src/arch/power/isa_traits.hh b/src/arch/power/isa_traits.hh index 393073bf7..3abc831ff 100644 --- a/src/arch/power/isa_traits.hh +++ b/src/arch/power/isa_traits.hh @@ -61,9 +61,6 @@ const Addr NPtePageShift = PageShift - PteShift; const Addr NPtePage = ULL(1) << NPtePageShift; const Addr PteMask = NPtePage - 1; -const int LogVMPageSize = 12; // 4K bytes -const int VMPageSize = (1 << LogVMPageSize); - const int MachineBytes = 4; // This is ori 0, 0, 0 diff --git a/src/arch/power/process.cc b/src/arch/power/process.cc index 175a84f6b..3dc2c0d17 100644 --- a/src/arch/power/process.cc +++ b/src/arch/power/process.cc @@ -56,7 +56,7 @@ PowerLiveProcess::PowerLiveProcess(LiveProcessParams *params, // Set up break point (Top of Heap) brk_point = objFile->dataBase() + objFile->dataSize() + objFile->bssSize(); - brk_point = roundUp(brk_point, VMPageSize); + brk_point = roundUp(brk_point, PageBytes); // Set up region for mmaps. For now, start at bottom of kuseg space. mmap_start = mmap_end = 0x70000000L; @@ -67,7 +67,7 @@ PowerLiveProcess::initState() { Process::initState(); - argsInit(MachineBytes, VMPageSize); + argsInit(MachineBytes, PageBytes); } void @@ -98,7 +98,7 @@ PowerLiveProcess::argsInit(int intSize, int pageSize) //XXX Figure out what these should be auxv.push_back(auxv_t(M5_AT_HWCAP, features)); //The system page size - auxv.push_back(auxv_t(M5_AT_PAGESZ, PowerISA::VMPageSize)); + auxv.push_back(auxv_t(M5_AT_PAGESZ, PowerISA::PageBytes)); //Frequency at which times() increments auxv.push_back(auxv_t(M5_AT_CLKTCK, 0x64)); // For statically linked executables, this is the virtual address of the -- cgit v1.2.3