From 554ddc7c074b0d9793a6c4972e1c449a57b94590 Mon Sep 17 00:00:00 2001 From: Andreas Hansson Date: Tue, 5 May 2015 03:22:27 -0400 Subject: arch, cpu: Do not forward snoops to table walker This patch simplifies the overall CPU by changing the TLB caches such that they do not forward snoops to the table walker port(s). Note that only ARM and X86 are affected. There is no reason for the ports to snoop as they do not actually take any action, and from a performance point of view we are better of not snooping more than we have to. Should it at a later point be required to snoop for a particular TLB design it is easy enough to add it back. --- src/arch/x86/pagetable_walker.hh | 8 -------- 1 file changed, 8 deletions(-) (limited to 'src/arch/x86/pagetable_walker.hh') diff --git a/src/arch/x86/pagetable_walker.hh b/src/arch/x86/pagetable_walker.hh index 181d6fb6c..9be35e6cc 100644 --- a/src/arch/x86/pagetable_walker.hh +++ b/src/arch/x86/pagetable_walker.hh @@ -70,15 +70,7 @@ namespace X86ISA Walker *walker; bool recvTimingResp(PacketPtr pkt); - - /** - * Snooping a coherence request, do nothing. - */ - void recvTimingSnoopReq(PacketPtr pkt) { } - Tick recvAtomicSnoop(PacketPtr pkt) { return 0; } - void recvFunctionalSnoop(PacketPtr pkt) { } void recvReqRetry(); - bool isSnooping() const { return true; } }; friend class WalkerPort; -- cgit v1.2.3