From 28a0e5a165842bb3e5bed144cc5b64437810e4fb Mon Sep 17 00:00:00 2001 From: Steve Reinhardt Date: Sun, 17 Jan 2016 18:27:46 -0800 Subject: sim: don't ignore SIG_TRAP By ignoring SIG_TRAP, using --debug-break when not connected to a debugger becomes a no-op. Apparently this was intended to be a feature, though the rationale is not clear. If we don't ignore SIG_TRAP, then using --debug-break when not connected to a debugger causes the simulation process to terminate at tick N. This is occasionally useful, e.g., if you just want to collect a trace for a specific window of execution then you can combine this with --debug-start to do exactly that. In addition to not ignoring the signal, this patch also updates the --debug-break help message and deletes a handful of unprotected calls to Debug::breakpoint() that relied on the prior behavior. --- src/arch/alpha/ev5.cc | 5 ----- 1 file changed, 5 deletions(-) (limited to 'src/arch') diff --git a/src/arch/alpha/ev5.cc b/src/arch/alpha/ev5.cc index d45786a83..1e8231b66 100644 --- a/src/arch/alpha/ev5.cc +++ b/src/arch/alpha/ev5.cc @@ -271,11 +271,6 @@ ISA::setIpr(int idx, uint64_t val, ThreadContext *tc) break; case IPR_IPLR: -#ifdef DEBUG - if (break_ipl != -1 && break_ipl == (int)(val & 0x1f)) - Debug::breakpoint(); -#endif - // only write least significant five bits - interrupt level ipr[idx] = val & 0x1f; if (tc->getKernelStats()) -- cgit v1.2.3