From d66b14ca61bec95a4049e5aae468904395055efd Mon Sep 17 00:00:00 2001
From: Andreas Hansson <andreas.hansson@arm.com>
Date: Mon, 24 Nov 2014 09:03:38 -0500
Subject: misc: Another round of static analysis fixups

Mostly addressing uninitialised members.
---
 src/base/bigint.hh     | 9 +++------
 src/base/remote_gdb.cc | 5 +++--
 2 files changed, 6 insertions(+), 8 deletions(-)

(limited to 'src/base')

diff --git a/src/base/bigint.hh b/src/base/bigint.hh
index a4e8738d3..2fa441a73 100644
--- a/src/base/bigint.hh
+++ b/src/base/bigint.hh
@@ -39,13 +39,10 @@
 struct m5_twin64_t {
     uint64_t a;
     uint64_t b;
-    m5_twin64_t()
+    m5_twin64_t() : a(0), b(0)
+    {}
+    m5_twin64_t(const uint64_t x) : a(x), b(x)
     {}
-    m5_twin64_t(const uint64_t x)
-    {
-        a = x;
-        b = x;
-    }
     inline m5_twin64_t& operator=(const uint64_t x)
     {
         a = x;
diff --git a/src/base/remote_gdb.cc b/src/base/remote_gdb.cc
index 49b7ce50d..ead8db9ae 100644
--- a/src/base/remote_gdb.cc
+++ b/src/base/remote_gdb.cc
@@ -658,12 +658,13 @@ BaseRemoteGDB::trap(int type)
      * After the debugger is "active" (connected) it will be
      * waiting for a "signaled" message from us.
      */
-    if (!active)
+    if (!active) {
         active = true;
-    else
+    } else {
         // Tell remote host that an exception has occurred.
         snprintf((char *)buffer, bufferSize, "S%02x", type);
         send(buffer);
+    }
 
     // Stick frame regs into our reg cache.
     getregs();
-- 
cgit v1.2.3