From 0be64ffe2f4ff8824b3084362706ffbf456ea490 Mon Sep 17 00:00:00 2001 From: Steve Reinhardt Date: Sat, 31 May 2014 18:00:23 -0700 Subject: style: eliminate equality tests with true and false Using '== true' in a boolean expression is totally redundant, and using '== false' is pretty verbose (and arguably less readable in most cases) compared to '!'. It's somewhat of a pet peeve, perhaps, but I had some time waiting for some tests to run and decided to clean these up. Unfortunately, SLICC appears not to have the '!' operator, so I had to leave the '== false' tests in the SLICC code. --- src/cpu/inorder/pipeline_stage.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'src/cpu/inorder/pipeline_stage.cc') diff --git a/src/cpu/inorder/pipeline_stage.cc b/src/cpu/inorder/pipeline_stage.cc index d98fbb744..5e94c665f 100644 --- a/src/cpu/inorder/pipeline_stage.cc +++ b/src/cpu/inorder/pipeline_stage.cc @@ -248,19 +248,19 @@ void PipelineStage::removeStalls(ThreadID tid) { for (int st_num = 0; st_num < NumStages; st_num++) { - if (stalls[tid].stage[st_num] == true) { + if (stalls[tid].stage[st_num]) { DPRINTF(InOrderStage, "Removing stall from stage %i.\n", st_num); stalls[tid].stage[st_num] = false; } - if (toPrevStages->stageBlock[st_num][tid] == true) { + if (toPrevStages->stageBlock[st_num][tid]) { DPRINTF(InOrderStage, "Removing pending block from stage %i.\n", st_num); toPrevStages->stageBlock[st_num][tid] = false; } - if (fromNextStages->stageBlock[st_num][tid] == true) { + if (fromNextStages->stageBlock[st_num][tid]) { DPRINTF(InOrderStage, "Removing pending block from stage %i.\n", st_num); fromNextStages->stageBlock[st_num][tid] = false; -- cgit v1.2.3