From ef71a987c1987f7543d3bf76ed9e5ce62f4d1daa Mon Sep 17 00:00:00 2001 From: Andreas Sandberg Date: Fri, 25 Jan 2019 14:26:21 +0000 Subject: python: Don't assume SimObjects live in the global namespace The importer in Python 3 doesn't like the way we import SimObjects from the global namespace. Convert the existing SimObject declarations to import from m5.objects. As a side-effect, this makes these files consistent with configuration files. Change-Id: I11153502b430822130722839e1fa767b82a027aa Signed-off-by: Andreas Sandberg Reviewed-on: https://gem5-review.googlesource.com/c/15981 Reviewed-by: Jason Lowe-Power Reviewed-by: Giacomo Travaglini --- src/cpu/o3/FUPool.py | 4 ++-- src/cpu/o3/FuncUnitConfig.py | 3 ++- src/cpu/o3/O3CPU.py | 11 ++++++----- src/cpu/o3/O3Checker.py | 2 +- src/cpu/o3/probe/ElasticTrace.py | 2 +- src/cpu/o3/probe/SimpleTrace.py | 2 +- 6 files changed, 13 insertions(+), 11 deletions(-) (limited to 'src/cpu/o3') diff --git a/src/cpu/o3/FUPool.py b/src/cpu/o3/FUPool.py index 0f4ea67c7..1461b405c 100644 --- a/src/cpu/o3/FUPool.py +++ b/src/cpu/o3/FUPool.py @@ -28,8 +28,8 @@ from m5.SimObject import SimObject from m5.params import * -from FuncUnit import * -from FuncUnitConfig import * +from m5.objects.FuncUnit import * +from m5.objects.FuncUnitConfig import * class FUPool(SimObject): type = 'FUPool' diff --git a/src/cpu/o3/FuncUnitConfig.py b/src/cpu/o3/FuncUnitConfig.py index f0c70f55a..ef114df09 100644 --- a/src/cpu/o3/FuncUnitConfig.py +++ b/src/cpu/o3/FuncUnitConfig.py @@ -41,7 +41,8 @@ from m5.SimObject import SimObject from m5.defines import buildEnv from m5.params import * -from FuncUnit import * + +from m5.objects.FuncUnit import * class IntALU(FUDesc): opList = [ OpDesc(opClass='IntAlu') ] diff --git a/src/cpu/o3/O3CPU.py b/src/cpu/o3/O3CPU.py index e73c09334..8e17d9a3f 100644 --- a/src/cpu/o3/O3CPU.py +++ b/src/cpu/o3/O3CPU.py @@ -43,10 +43,11 @@ from __future__ import print_function from m5.defines import buildEnv from m5.params import * from m5.proxy import * -from BaseCPU import BaseCPU -from FUPool import * -from O3Checker import O3Checker -from BranchPredictor import * + +from m5.objects.BaseCPU import BaseCPU +from m5.objects.FUPool import * +from m5.objects.O3Checker import O3Checker +from m5.objects.BranchPredictor import * class FetchPolicy(ScopedEnum): vals = [ 'SingleThread', 'RoundRobin', 'Branch', 'IQCount', 'LSQCount' ] @@ -178,7 +179,7 @@ class DerivO3CPU(BaseCPU): def addCheckerCpu(self): if buildEnv['TARGET_ISA'] in ['arm']: - from ArmTLB import ArmTLB + from m5.objects.ArmTLB import ArmTLB self.checker = O3Checker(workload=self.workload, exitOnError=False, diff --git a/src/cpu/o3/O3Checker.py b/src/cpu/o3/O3Checker.py index f21a038c4..20d59c1f4 100644 --- a/src/cpu/o3/O3Checker.py +++ b/src/cpu/o3/O3Checker.py @@ -27,7 +27,7 @@ # Authors: Nathan Binkert from m5.params import * -from CheckerCPU import CheckerCPU +from m5.objects.CheckerCPU import CheckerCPU class O3Checker(CheckerCPU): type = 'O3Checker' diff --git a/src/cpu/o3/probe/ElasticTrace.py b/src/cpu/o3/probe/ElasticTrace.py index 20057ab97..d60681d3f 100644 --- a/src/cpu/o3/probe/ElasticTrace.py +++ b/src/cpu/o3/probe/ElasticTrace.py @@ -37,7 +37,7 @@ # Andreas Hansson # Thomas Grass -from Probe import * +from m5.objects.Probe import * class ElasticTrace(ProbeListenerObject): type = 'ElasticTrace' diff --git a/src/cpu/o3/probe/SimpleTrace.py b/src/cpu/o3/probe/SimpleTrace.py index eeec58ef0..9572aa218 100644 --- a/src/cpu/o3/probe/SimpleTrace.py +++ b/src/cpu/o3/probe/SimpleTrace.py @@ -35,7 +35,7 @@ # # Authors: Matt Horsnell -from Probe import * +from m5.objects.Probe import * class SimpleTrace(ProbeListenerObject): type = 'SimpleTrace' -- cgit v1.2.3