From 25ec278a0be5e3e09d396ef5be993e45b766790b Mon Sep 17 00:00:00 2001 From: Nilay Vaish Date: Sat, 12 Jan 2013 22:09:48 -0600 Subject: x86: Changes to decoder, corrects 9376 The changes made by the changeset 9376 were not quite correct. The patch made changes to the code which resulted in decoder not getting initialized correctly when the state was restored from a checkpoint. This patch adds a startup function to each ISA object. For x86, this function sets the required state in the decoder. For other ISAs, the function is empty right now. --- src/cpu/o3/cpu.cc | 3 +++ src/cpu/simple/base.cc | 7 +++++++ src/cpu/simple/base.hh | 2 ++ src/cpu/simple_thread.cc | 6 ++++++ src/cpu/simple_thread.hh | 1 + 5 files changed, 19 insertions(+) (limited to 'src/cpu') diff --git a/src/cpu/o3/cpu.cc b/src/cpu/o3/cpu.cc index 18c536090..393b9a189 100644 --- a/src/cpu/o3/cpu.cc +++ b/src/cpu/o3/cpu.cc @@ -678,6 +678,9 @@ template void FullO3CPU::startup() { + for (int tid = 0; tid < numThreads; ++tid) + isa[tid]->startup(threadContexts[tid]); + fetch.startupStage(); decode.startupStage(); iew.startupStage(); diff --git a/src/cpu/simple/base.cc b/src/cpu/simple/base.cc index 13e08a6cb..4db1c6c10 100644 --- a/src/cpu/simple/base.cc +++ b/src/cpu/simple/base.cc @@ -515,6 +515,13 @@ BaseSimpleCPU::advancePC(Fault fault) } } +void +BaseSimpleCPU::startup() +{ + BaseCPU::startup(); + thread->startup(); +} + /*Fault BaseSimpleCPU::CacheOp(uint8_t Op, Addr EffAddr) { diff --git a/src/cpu/simple/base.hh b/src/cpu/simple/base.hh index 18b97c42f..7e84dcc16 100644 --- a/src/cpu/simple/base.hh +++ b/src/cpu/simple/base.hh @@ -172,6 +172,8 @@ class BaseSimpleCPU : public BaseCPU virtual void regStats(); virtual void resetStats(); + virtual void startup(); + // number of simulated instructions Counter numInst; Counter startNumInst; diff --git a/src/cpu/simple_thread.cc b/src/cpu/simple_thread.cc index 9cf8da7b4..77569aa68 100644 --- a/src/cpu/simple_thread.cc +++ b/src/cpu/simple_thread.cc @@ -142,6 +142,12 @@ SimpleThread::unserialize(Checkpoint *cp, const std::string §ion) ::unserialize(*tc, cp, section); } +void +SimpleThread::startup() +{ + isa->startup(tc); +} + void SimpleThread::dumpFuncProfile() { diff --git a/src/cpu/simple_thread.hh b/src/cpu/simple_thread.hh index 6f1173b7f..d752ed105 100644 --- a/src/cpu/simple_thread.hh +++ b/src/cpu/simple_thread.hh @@ -150,6 +150,7 @@ class SimpleThread : public ThreadState void serialize(std::ostream &os); void unserialize(Checkpoint *cp, const std::string §ion); + void startup(); /*************************************************************** * SimpleThread functions to provide CPU with access to various -- cgit v1.2.3