From dc456d8166fce16c3af26f09405b0bf91ff1e38f Mon Sep 17 00:00:00 2001 From: Pritha Ghoshal Date: Thu, 10 May 2012 18:04:26 -0500 Subject: IGbE: Fix writeback conditions for i8254x GbE in updated data sheet. An older revision of the data sheet specified that txdctl.gran was 1 the granularity was based on cache block and gran being 0 is based on descriptor count. The newer version of the data sheet reverses this errata --- src/dev/i8254xGBe.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/dev/i8254xGBe.cc') diff --git a/src/dev/i8254xGBe.cc b/src/dev/i8254xGBe.cc index effc2a589..29bd5adc2 100644 --- a/src/dev/i8254xGBe.cc +++ b/src/dev/i8254xGBe.cc @@ -1923,12 +1923,12 @@ IGbE::TxDescCache::pktComplete() igbe->anBegin("TXS", "Desc Writeback"); DPRINTF(EthernetDesc, "WTHRESH == 0, writing back descriptor\n"); writeback(0); - } else if (igbe->regs.txdctl.gran() && igbe->regs.txdctl.wthresh() >= + } else if (!igbe->regs.txdctl.gran() && igbe->regs.txdctl.wthresh() <= descInBlock(usedCache.size())) { DPRINTF(EthernetDesc, "used > WTHRESH, writing back descriptor\n"); igbe->anBegin("TXS", "Desc Writeback"); writeback((igbe->cacheBlockSize()-1)>>4); - } else if (igbe->regs.txdctl.wthresh() >= usedCache.size()) { + } else if (igbe->regs.txdctl.wthresh() <= usedCache.size()) { DPRINTF(EthernetDesc, "used > WTHRESH, writing back descriptor\n"); igbe->anBegin("TXS", "Desc Writeback"); writeback((igbe->cacheBlockSize()-1)>>4); -- cgit v1.2.3