From d66b14ca61bec95a4049e5aae468904395055efd Mon Sep 17 00:00:00 2001 From: Andreas Hansson Date: Mon, 24 Nov 2014 09:03:38 -0500 Subject: misc: Another round of static analysis fixups Mostly addressing uninitialised members. --- src/dev/virtio/base.cc | 3 ++- src/dev/virtio/base.hh | 2 +- src/dev/virtio/fs9p.cc | 2 +- src/dev/virtio/pci.cc | 4 ++-- 4 files changed, 6 insertions(+), 5 deletions(-) (limited to 'src/dev/virtio') diff --git a/src/dev/virtio/base.cc b/src/dev/virtio/base.cc index 79304cf1d..44cce65c4 100644 --- a/src/dev/virtio/base.cc +++ b/src/dev/virtio/base.cc @@ -43,7 +43,8 @@ VirtDescriptor::VirtDescriptor(PortProxy &_memProxy, VirtQueue &_queue, Index descIndex) - : memProxy(&_memProxy), queue(&_queue), _index(descIndex) + : memProxy(&_memProxy), queue(&_queue), _index(descIndex), + desc{0, 0, 0, 0} { } diff --git a/src/dev/virtio/base.hh b/src/dev/virtio/base.hh index 4695f2b96..fe1685767 100644 --- a/src/dev/virtio/base.hh +++ b/src/dev/virtio/base.hh @@ -479,7 +479,7 @@ public: } M5_ATTR_PACKED; VirtRing(PortProxy &proxy, uint16_t size) - : ring(size), _proxy(proxy), _base(0) {} + : header{0, 0}, ring(size), _proxy(proxy), _base(0) {} /** * Set the base address of the VirtIO ring buffer. diff --git a/src/dev/virtio/fs9p.cc b/src/dev/virtio/fs9p.cc index b09ab15aa..4861821d7 100644 --- a/src/dev/virtio/fs9p.cc +++ b/src/dev/virtio/fs9p.cc @@ -291,7 +291,7 @@ VirtIO9PProxy::writeAll(const uint8_t *data, size_t len) VirtIO9PDiod::VirtIO9PDiod(Params *params) : VirtIO9PProxy(params), - fd_to_diod(-1), fd_from_diod(-1) + fd_to_diod(-1), fd_from_diod(-1), diod_pid(-1) { } diff --git a/src/dev/virtio/pci.cc b/src/dev/virtio/pci.cc index 399590c1b..1f99d7fe4 100644 --- a/src/dev/virtio/pci.cc +++ b/src/dev/virtio/pci.cc @@ -43,8 +43,8 @@ #include "params/PciVirtIO.hh" PciVirtIO::PciVirtIO(const Params *params) - : PciDevice(params), vio(*params->vio), - callbackKick(this) + : PciDevice(params), queueNotify(0), interruptDeliveryPending(false), + vio(*params->vio), callbackKick(this) { // Override the subsystem ID with the device ID from VirtIO config.subsystemID = htole(vio.deviceId); -- cgit v1.2.3