From 0ecaab4ea8039f707a95f5e3efcc68591dbcd407 Mon Sep 17 00:00:00 2001 From: Joel Hestness Date: Tue, 29 Sep 2015 09:28:26 -0500 Subject: arch, x86: Delete packet in IntDevice::recvResponse IntDevice::recvResponse is called from two places in current mainline: (1) the short circuit path of X86ISA::IntDevice::IntMasterPort::sendMessage for atomic mode, and (2) the full request->response path to and from the x86 interrupts device (finally called from MessageMasterPort::recvTimingResp). In the former case, the packet was deleted correctly, but in the latter case, the packet and request leak. To fix the leak, move request and packet deletion into IntDevice inherited class implementations of recvResponse. --- src/dev/x86/intdev.hh | 1 + 1 file changed, 1 insertion(+) (limited to 'src/dev/x86/intdev.hh') diff --git a/src/dev/x86/intdev.hh b/src/dev/x86/intdev.hh index d63e64010..65ad8727d 100644 --- a/src/dev/x86/intdev.hh +++ b/src/dev/x86/intdev.hh @@ -150,6 +150,7 @@ class IntDevice virtual Tick recvResponse(PacketPtr pkt) { + panic("recvResponse not implemented.\n"); return 0; } -- cgit v1.2.3