From a62afd094b75f52471ff2556c62c9c5f53d705e6 Mon Sep 17 00:00:00 2001 From: Andreas Hansson Date: Tue, 19 Feb 2013 05:56:08 -0500 Subject: scons: Fix warnings issued by clang 3.2svn (XCode 4.6) This patch fixes the warnings that clang3.2svn emit due to the "-Wall" flag. There is one case of an uninitialised value in the ARM neon ISA description, and then a whole range of unused private fields that are pruned. --- src/dev/Ethernet.py | 2 -- src/dev/alpha/tsunami_io.hh | 2 -- src/dev/i8254xGBe.cc | 1 - src/dev/i8254xGBe.hh | 3 --- src/dev/x86/intdev.hh | 6 +++--- 5 files changed, 3 insertions(+), 11 deletions(-) (limited to 'src/dev') diff --git a/src/dev/Ethernet.py b/src/dev/Ethernet.py index 191aad3a1..0072b90fa 100644 --- a/src/dev/Ethernet.py +++ b/src/dev/Ethernet.py @@ -78,8 +78,6 @@ class IGbE(EtherDevice): cxx_header = "dev/i8254xGBe.hh" hardware_address = Param.EthernetAddr(NextEthernetAddr, "Ethernet Hardware Address") - use_flow_control = Param.Bool(False, - "Should we use xon/xoff flow contorl (UNIMPLEMENTD)") rx_fifo_size = Param.MemorySize('384kB', "Size of the rx FIFO") tx_fifo_size = Param.MemorySize('384kB', "Size of the tx FIFO") rx_desc_cache_size = Param.Int(64, diff --git a/src/dev/alpha/tsunami_io.hh b/src/dev/alpha/tsunami_io.hh index 7477fb124..684295551 100644 --- a/src/dev/alpha/tsunami_io.hh +++ b/src/dev/alpha/tsunami_io.hh @@ -51,8 +51,6 @@ */ class TsunamiIO : public BasicPioDevice { - private: - struct tm tm; protected: diff --git a/src/dev/i8254xGBe.cc b/src/dev/i8254xGBe.cc index 9a3ddaeb7..ee24b3922 100644 --- a/src/dev/i8254xGBe.cc +++ b/src/dev/i8254xGBe.cc @@ -58,7 +58,6 @@ using namespace Net; IGbE::IGbE(const Params *p) : EtherDevice(p), etherInt(NULL), drainManager(NULL), - useFlowControl(p->use_flow_control), rxFifo(p->rx_fifo_size), txFifo(p->tx_fifo_size), rxTick(false), txTick(false), txFifoTick(false), rxDmaPacket(false), pktOffset(0), fetchDelay(p->fetch_delay), wbDelay(p->wb_delay), diff --git a/src/dev/i8254xGBe.hh b/src/dev/i8254xGBe.hh index b8099fb1c..295712717 100644 --- a/src/dev/i8254xGBe.hh +++ b/src/dev/i8254xGBe.hh @@ -70,9 +70,6 @@ class IGbE : public EtherDevice // The drain event if we have one DrainManager *drainManager; - // cached parameters from params struct - bool useFlowControl; - // packet fifos PacketFifo rxFifo; PacketFifo txFifo; diff --git a/src/dev/x86/intdev.hh b/src/dev/x86/intdev.hh index a94ca47cc..99c361bae 100644 --- a/src/dev/x86/intdev.hh +++ b/src/dev/x86/intdev.hh @@ -66,11 +66,11 @@ class IntDev class IntSlavePort : public MessageSlavePort { IntDev * device; - Tick latency; + public: IntSlavePort(const std::string& _name, MemObject* _parent, - IntDev* dev, Tick _latency) : - MessageSlavePort(_name, _parent), device(dev), latency(_latency) + IntDev* dev) : + MessageSlavePort(_name, _parent), device(dev) { } -- cgit v1.2.3