From f54020eb8155371725ab75b0fc5c419287eca084 Mon Sep 17 00:00:00 2001 From: Giacomo Travaglini Date: Mon, 4 Jun 2018 09:40:19 +0100 Subject: misc: Using smart pointers for memory Requests This patch is changing the underlying type for RequestPtr from Request* to shared_ptr. Having memory requests being managed by smart pointers will simplify the code; it will also prevent memory leakage and dangling pointers. Change-Id: I7749af38a11ac8eb4d53d8df1252951e0890fde3 Signed-off-by: Giacomo Travaglini Reviewed-by: Andreas Sandberg Reviewed-on: https://gem5-review.googlesource.com/10996 Reviewed-by: Nikos Nikoleris Maintainer: Nikos Nikoleris --- src/gpu-compute/fetch_unit.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'src/gpu-compute/fetch_unit.cc') diff --git a/src/gpu-compute/fetch_unit.cc b/src/gpu-compute/fetch_unit.cc index 36ef1e1e8..a9cea9bf6 100644 --- a/src/gpu-compute/fetch_unit.cc +++ b/src/gpu-compute/fetch_unit.cc @@ -145,8 +145,9 @@ FetchUnit::initiateFetch(Wavefront *wavefront) } // set up virtual request - RequestPtr req = new Request(0, vaddr, size, Request::INST_FETCH, - computeUnit->masterId(), 0, 0, 0); + RequestPtr req = std::make_shared( + 0, vaddr, size, Request::INST_FETCH, + computeUnit->masterId(), 0, 0, nullptr); PacketPtr pkt = new Packet(req, MemCmd::ReadReq); // This fetchBlock is kind of faux right now - because the translations so @@ -306,7 +307,6 @@ FetchUnit::processFetchReturn(PacketPtr pkt) wavefront->pendingFetch = false; delete pkt->senderState; - delete pkt->req; delete pkt; } -- cgit v1.2.3