From 71da1d21578b6f9cf5b43bd4648f313326849533 Mon Sep 17 00:00:00 2001 From: Andreas Hansson Date: Mon, 7 Jan 2013 13:05:38 -0500 Subject: base: Encapsulate the underlying fields in AddrRange This patch makes the start and end address private in a move to prevent direct manipulation and matching of ranges based on these fields. This is done so that a transition to ranges with interleaving support is possible. As a result of hiding the start and end, a number of member functions are needed to perform the comparisons and manipulations that previously took place directly on the members. An accessor function is provided for the start address, and a function is added to test if an address is within a range. As a result of the latter the != and == operator is also removed in favour of the member function. A member function that returns a string representation is also created to allow debug printing. In general, this patch does not add any functionality, but it does take us closer to a situation where interleaving (and more cleverness) can be added under the bonnet without exposing it to the user. More on that in a later patch. --- src/kern/tru64/tru64_events.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/kern') diff --git a/src/kern/tru64/tru64_events.cc b/src/kern/tru64/tru64_events.cc index fd4c20bdd..943d961fb 100644 --- a/src/kern/tru64/tru64_events.cc +++ b/src/kern/tru64/tru64_events.cc @@ -65,7 +65,7 @@ BadAddrEvent::process(ThreadContext *tc) // get the address ranges of the connected slave port AddrRangeList resp = dataPort.getAddrRanges(); for (iter = resp.begin(); iter != resp.end(); iter++) { - if (*iter == (K0Seg2Phys(a0) & PAddrImplMask)) + if (iter->contains(K0Seg2Phys(a0) & PAddrImplMask)) found = true; } -- cgit v1.2.3