From 2f17062dd9a465943b57723f72f89ec66a0db664 Mon Sep 17 00:00:00 2001 From: Robert Kovacsics Date: Thu, 19 Jul 2018 18:56:06 +0100 Subject: mem: Rename Packet::checkFunctional to trySatisfyFunctional Packet::checkFunctional also wrote data to/from the packet depending on if it was read/write, respectively, which the 'check' in the name would suggest otherwise. This renames it to doFunctional, which is more suggestive. It also renames any function called checkFunctional which calls Packet::checkFunctional. These are - Bridge::BridgeMasterPort::checkFunctional - calls Packet::checkFunctional - MSHR::checkFunctional - calls Packet::checkFunctional - MSHR::TargetList::checkFunctional - calls Packet::checkFunctional - Queue<>::checkFunctional (of src/mem/cache/queue.hh, not src/cpu/minor/buffers.h) - Instantiated with Queue and Queue - WriteQueueEntry - calls Packet::checkFunctional - WriteQueueEntry::TargetList - calls Packet::checkFunctional - MemDelay::checkFunctional - calls QueuedSlavePort/QueuedMasterPort::checkFunctional - Packet::checkFunctional - PacketQueue::checkFunctional - calls Packet::checkFunctional - QueuedSlavePort::checkFunctional - calls PacketQueue::doFunctional - QueuedMasterPort::checkFunctional - calls PacketQueue::doFunctional - SerialLink::SerialLinkMasterPort::checkFunctional - calls Packet::doFunctional Change-Id: Ieca2579c020c329040da053ba8e25820801b62c5 Reviewed-on: https://gem5-review.googlesource.com/11810 Reviewed-by: Daniel Carvalho Reviewed-by: Jason Lowe-Power Maintainer: Jason Lowe-Power --- src/mem/bridge.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'src/mem/bridge.cc') diff --git a/src/mem/bridge.cc b/src/mem/bridge.cc index 0c9e2c15a..1066f47a0 100644 --- a/src/mem/bridge.cc +++ b/src/mem/bridge.cc @@ -361,14 +361,14 @@ Bridge::BridgeSlavePort::recvFunctional(PacketPtr pkt) // check the response queue for (auto i = transmitList.begin(); i != transmitList.end(); ++i) { - if (pkt->checkFunctional((*i).pkt)) { + if (pkt->trySatisfyFunctional((*i).pkt)) { pkt->makeResponse(); return; } } // also check the master port's request queue - if (masterPort.checkFunctional(pkt)) { + if (masterPort.trySatisfyFunctional(pkt)) { return; } @@ -379,13 +379,13 @@ Bridge::BridgeSlavePort::recvFunctional(PacketPtr pkt) } bool -Bridge::BridgeMasterPort::checkFunctional(PacketPtr pkt) +Bridge::BridgeMasterPort::trySatisfyFunctional(PacketPtr pkt) { bool found = false; auto i = transmitList.begin(); while (i != transmitList.end() && !found) { - if (pkt->checkFunctional((*i).pkt)) { + if (pkt->trySatisfyFunctional((*i).pkt)) { pkt->makeResponse(); found = true; } -- cgit v1.2.3