From d8b7a652e1c460ac5b3b935022d45eeb338f7665 Mon Sep 17 00:00:00 2001 From: Andreas Hansson Date: Thu, 29 Oct 2015 08:48:20 -0400 Subject: mem: Clarify cache MSHR handling on fill This patch addresses the upgrading of deferred targets in the MSHR, and makes it clearer by explicitly calling out what is happening (deferred targets are promoted if we get exclusivity without asking for it). --- src/mem/cache/mshr.cc | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'src/mem/cache/mshr.cc') diff --git a/src/mem/cache/mshr.cc b/src/mem/cache/mshr.cc index 085b8dae0..f71ff6524 100644 --- a/src/mem/cache/mshr.cc +++ b/src/mem/cache/mshr.cc @@ -430,11 +430,10 @@ MSHR::promoteDeferredTargets() void -MSHR::handleFill(PacketPtr pkt, CacheBlk *blk) +MSHR::promoteExclusive() { - if (!pkt->sharedAsserted() - && !(hasPostInvalidate() || hasPostDowngrade()) - && deferredTargets.needsExclusive) { + if (deferredTargets.needsExclusive && + !(hasPostInvalidate() || hasPostDowngrade())) { // We got an exclusive response, but we have deferred targets // which are waiting to request an exclusive copy (not because // of a pending invalidate). This can happen if the original -- cgit v1.2.3