From 2cb5467e8514934c4d88304c65050adead0ffc7e Mon Sep 17 00:00:00 2001 From: Andreas Hansson Date: Fri, 6 Nov 2015 03:26:16 -0500 Subject: misc: Appease clang static analyzer A few minor fixes to issues identified by the clang static analyzer. --- src/mem/dram_ctrl.cc | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) (limited to 'src/mem/dram_ctrl.cc') diff --git a/src/mem/dram_ctrl.cc b/src/mem/dram_ctrl.cc index dc2c03332..3ba4616f7 100644 --- a/src/mem/dram_ctrl.cc +++ b/src/mem/dram_ctrl.cc @@ -341,9 +341,8 @@ DRAMCtrl::decodeAddr(PacketPtr pkt, Addr dramPktAddr, unsigned size, rank = addr % ranksPerChannel; addr = addr / ranksPerChannel; - // lastly, get the row bits + // lastly, get the row bits, no need to remove them from addr row = addr % rowsPerBank; - addr = addr / rowsPerBank; } else if (addrMapping == Enums::RoRaBaCoCh) { // take out the lower-order column bits addr = addr / columnsPerStripe; @@ -364,9 +363,8 @@ DRAMCtrl::decodeAddr(PacketPtr pkt, Addr dramPktAddr, unsigned size, rank = addr % ranksPerChannel; addr = addr / ranksPerChannel; - // lastly, get the row bits + // lastly, get the row bits, no need to remove them from addr row = addr % rowsPerBank; - addr = addr / rowsPerBank; } else if (addrMapping == Enums::RoCoRaBaCh) { // optimise for closed page mode and utilise maximum // parallelism of the DRAM (at the cost of power) @@ -391,9 +389,8 @@ DRAMCtrl::decodeAddr(PacketPtr pkt, Addr dramPktAddr, unsigned size, // next, the higher-order column bites addr = addr / (columnsPerRowBuffer / columnsPerStripe); - // lastly, get the row bits + // lastly, get the row bits, no need to remove them from addr row = addr % rowsPerBank; - addr = addr / rowsPerBank; } else panic("Unknown address mapping policy chosen!"); -- cgit v1.2.3