From 292d8252a4a03b7f2ef48f6f86311ac35020095d Mon Sep 17 00:00:00 2001
From: Andreas Hansson <andreas.hansson@arm.com>
Date: Tue, 11 Sep 2012 14:15:47 -0400
Subject: clang: Fix issues identified by the clang static analyzer

This patch addresses a few minor issues reported by the clang static
analyzer.

The analysis was run with:

scan-build -disable-checker deadcode \
           -enable-checker experimental.core \
           -disable-checker experimental.core.CastToStruct \
           -enable-checker experimental.cpluscplus
---
 src/mem/ruby/system/Sequencer.cc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

(limited to 'src/mem/ruby/system/Sequencer.cc')

diff --git a/src/mem/ruby/system/Sequencer.cc b/src/mem/ruby/system/Sequencer.cc
index c48ff59cf..efb0b002e 100644
--- a/src/mem/ruby/system/Sequencer.cc
+++ b/src/mem/ruby/system/Sequencer.cc
@@ -645,8 +645,9 @@ Sequencer::makeRequest(PacketPtr pkt)
 void
 Sequencer::issueRequest(PacketPtr pkt, RubyRequestType secondary_type)
 {
+    assert(pkt != NULL);
     int proc_id = -1;
-    if (pkt != NULL && pkt->req->hasContextId()) {
+    if (pkt->req->hasContextId()) {
         proc_id = pkt->req->contextId();
     }
 
-- 
cgit v1.2.3