From de62aedabc96e7492c40bbc4468ba42b3274bfd6 Mon Sep 17 00:00:00 2001 From: Andreas Hansson Date: Sat, 27 Sep 2014 09:08:29 -0400 Subject: misc: Fix a bunch of minor issues identified by static analysis Add some missing initialisation, and fix a handful benign resource leaks (including some false positives). --- src/mem/ruby/system/RubyPort.cc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'src/mem/ruby/system') diff --git a/src/mem/ruby/system/RubyPort.cc b/src/mem/ruby/system/RubyPort.cc index 110b6924d..71b08ebbb 100644 --- a/src/mem/ruby/system/RubyPort.cc +++ b/src/mem/ruby/system/RubyPort.cc @@ -205,7 +205,11 @@ RubyPort::PioSlavePort::recvTimingReq(PacketPtr pkt) AddrRangeList l = ruby_port->master_ports[i]->getAddrRanges(); for (auto it = l.begin(); it != l.end(); ++it) { if (it->contains(pkt->getAddr())) { - ruby_port->master_ports[i]->sendTimingReq(pkt); + // generally it is not safe to assume success here as + // the port could be blocked + bool M5_VAR_USED success = + ruby_port->master_ports[i]->sendTimingReq(pkt); + assert(success); return true; } } -- cgit v1.2.3