From d7c4cad240fd4f378d7362da5e9e44b9f0dd80d3 Mon Sep 17 00:00:00 2001 From: Gabe Black Date: Wed, 1 May 2019 20:12:05 -0700 Subject: mem, arm: Replace the pointer type in PortProxy with void *. The void * type is for pointers which point to an unknown type. We should use that when handling anonymous buffers in the PortProxy functions, instead of uint8_t * which points to bytes. Importantly, C/C++ doesn't require you to do any casting to turn an arbitrary pointer type into a void *. This will get rid of lots of tedious, verbose casting throughout the code base. Change-Id: Id1adecc283c866d8e24524efd64f37b079088bd9 Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/18571 Tested-by: kokoro Reviewed-by: Andreas Sandberg Reviewed-by: Jason Lowe-Power Maintainer: Jason Lowe-Power --- src/mem/se_translating_port_proxy.hh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/mem/se_translating_port_proxy.hh') diff --git a/src/mem/se_translating_port_proxy.hh b/src/mem/se_translating_port_proxy.hh index 1c8828bbf..718e44a57 100644 --- a/src/mem/se_translating_port_proxy.hh +++ b/src/mem/se_translating_port_proxy.hh @@ -85,8 +85,8 @@ class SETranslatingPortProxy : public PortProxy void setPageTable(EmulationPageTable *p) { pTable = p; } void setProcess(Process *p) { process = p; } - bool tryReadBlob(Addr addr, uint8_t *p, int size) const override; - bool tryWriteBlob(Addr addr, const uint8_t *p, int size) const override; + bool tryReadBlob(Addr addr, void *p, int size) const override; + bool tryWriteBlob(Addr addr, const void *p, int size) const override; bool tryMemsetBlob(Addr addr, uint8_t val, int size) const override; }; -- cgit v1.2.3