From 8bc925e36d0e5de7e70a6d5bf2b1824649932599 Mon Sep 17 00:00:00 2001 From: Andreas Hansson Date: Fri, 6 Nov 2015 03:26:35 -0500 Subject: mem: Align rules for sinking inhibited packets at the slave This patch aligns how the memory-system slaves, i.e. the various memory controllers and the bridge, identify and deal with sinking of inhibited packets that are only useful within the coherent part of the memory system. In the future we could shift the onus to the crossbar, and add a parameter "is_point_of_coherence" that would allow it to sink the aforementioned packets. --- src/mem/simple_mem.cc | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) (limited to 'src/mem/simple_mem.cc') diff --git a/src/mem/simple_mem.cc b/src/mem/simple_mem.cc index 7e350feb6..639ccbe31 100644 --- a/src/mem/simple_mem.cc +++ b/src/mem/simple_mem.cc @@ -97,17 +97,15 @@ SimpleMemory::recvFunctional(PacketPtr pkt) bool SimpleMemory::recvTimingReq(PacketPtr pkt) { + // sink inhibited packets without further action if (pkt->memInhibitAsserted()) { - // snooper will supply based on copy of packet - // still target's responsibility to delete packet pendingDelete.reset(pkt); return true; } - // we should never get a new request after committing to retry the - // current one, the bus violates the rule as it simply sends a - // retry to the next one waiting on the retry list, so simply - // ignore it + // we should not get a new request after committing to retry the + // current one, but unfortunately the CPU violates this rule, so + // simply ignore it for now if (retryReq) return false; -- cgit v1.2.3