From 642818f1f39dd73e478f136d0306989f33d3ad8f Mon Sep 17 00:00:00 2001 From: Andreas Sandberg Date: Wed, 10 May 2017 10:57:27 +0100 Subject: python: Fix PyEvent reference counting bug The current implementation of reference counting for PyEvents only partially works. The native object is currently kept alive while it is in the event queue. However, if the Python object goes out of scope, the Python side of this object is garbage collected which leaves a "dangling" native object. This results in confusing error messages where PyBind is unable to find the Python implementation of an event when it is triggered. Implement reference counting using the generalized reference counting API instead. Change-Id: I4e8e04abc4f61dff238d718065f5371e73b38ab3 Signed-off-by: Andreas Sandberg Reviewed-by: Curtis Dunham Reviewed-on: https://gem5-review.googlesource.com/3222 Reviewed-by: Jason Lowe-Power --- src/python/m5/event.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/python/m5') diff --git a/src/python/m5/event.py b/src/python/m5/event.py index 20f81b93b..59d18b6fe 100644 --- a/src/python/m5/event.py +++ b/src/python/m5/event.py @@ -44,7 +44,8 @@ import m5 import _m5.event from _m5.event import GlobalSimLoopExitEvent as SimExit -from _m5.event import Event, getEventQueue, setEventQueue +from _m5.event import PyEvent as Event +from _m5.event import getEventQueue, setEventQueue mainq = None -- cgit v1.2.3