From 60b26f1546cdafc6d7349e669dae3cea39c9c5c4 Mon Sep 17 00:00:00 2001 From: Andreas Sandberg Date: Mon, 27 Feb 2017 11:25:01 +0000 Subject: base: Refactor logging to make log level selection cleaner It's currently possible to change the log level in gem5 by tweaking a set of global variables. These variables are currently exposed to Python using SWIG. This mechanism is far from ideal for two reasons: First, changing the log level requires that the Python world enables or disables individual levels. Ideally, this should be a single call where a log level is selected. Second, exporting global variables is poorly supported by most Python frameworks. SWIG puts variables in their own namespace and PyBind doesn't seem to support it at all. This changeset refactors the logging code to create a more abstract interface. Each log level is associated with an instance of a Logger class. This class contains common functionality, an enable flag, and a verbose flag. Available LogLevels are described by the LogLevel class. Lower log levels are used for more critical messages (PANIC being level 0) and higher levels for less critical messages. The highest log level that is printed is controlled by calling Logger:setLevel(). Change-Id: I31e44299d242d953197a8e62679250c91d6ef776 Signed-off-by: Andreas Sandberg Reviewed-by: Gabor Dozsa Reviewed-by: Curtis Dunham Reviewed-by: Jason Lowe-Power --- src/python/swig/core.i | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) (limited to 'src/python') diff --git a/src/python/swig/core.i b/src/python/swig/core.i index 45337c3a5..8b734b940 100644 --- a/src/python/swig/core.i +++ b/src/python/swig/core.i @@ -92,7 +92,20 @@ void serializeAll(const std::string &cpt_dir); CheckpointIn *getCheckpoint(const std::string &cpt_dir); void unserializeGlobals(CheckpointIn &cp); -bool want_warn, warn_verbose; -bool want_info, info_verbose; -bool want_hack, hack_verbose; - +class Logger +{ + public: + enum LogLevel { + PANIC = 0, + FATAL, + WARN, + INFO, + HACK, + NUM_LOG_LEVELS, + }; + + static void setLevel(LogLevel ll); + + private: + Logger(); +}; -- cgit v1.2.3