From 0f1efb84a33d737175ed66e977239fbebc06ca82 Mon Sep 17 00:00:00 2001 From: Gabe Black Date: Sun, 13 Oct 2019 21:43:36 -0700 Subject: sim,cpu: Get rid of the unused instEventQueue. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This queue was set up to allow triggering events based on the total number of instructions executed at the system level, and was added in a change which added a number of things to support McPAT. No code checked into gem5 actually schedules an event on that queue, and no code in McPAT (which seems to have gone dormant) either downloadable from github or found in ext modify gem5 in a way that makes it use the instEventQueue. Also, the KVM CPU does not interact with the instEventQueue correctly. While it does check the per-thread instruction event queue when deciding how long to run, it does not check the instEventQueue. It will poke it to run events when it stops for other reasons, but it may (and likely will) have run beyond the point where it was supposed to stop. Since this queue doesn't seem to actually be used for anything, isn't being used properly in all cases anyway, and adds overhead to all the CPU models, this change eliminates it. Change-Id: I0e126df14788c37a6d58ca9e1bb2686b70e60d88 Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/21783 Maintainer: Gabe Black Reviewed-by: Jason Lowe-Power Reviewed-by: Tiago Mück Tested-by: kokoro --- src/sim/system.cc | 1 - src/sim/system.hh | 1 - 2 files changed, 2 deletions(-) (limited to 'src/sim') diff --git a/src/sim/system.cc b/src/sim/system.cc index 87a220311..3868f57b8 100644 --- a/src/sim/system.cc +++ b/src/sim/system.cc @@ -112,7 +112,6 @@ System::System(Params *p) thermalModel(p->thermal_model), _params(p), totalNumInsts(0), - instEventQueue("system instruction-based event queue"), redirectPaths(p->redirect_paths) { diff --git a/src/sim/system.hh b/src/sim/system.hh index 345d83c2a..852bc21a2 100644 --- a/src/sim/system.hh +++ b/src/sim/system.hh @@ -605,7 +605,6 @@ class System : public SimObject public: Counter totalNumInsts; - EventQueue instEventQueue; std::map, Tick> lastWorkItemStarted; std::map workItemStats; -- cgit v1.2.3