From 7f2d7fe4ef622d861e55517279f193cdf8acfc99 Mon Sep 17 00:00:00 2001 From: Nikos Nikoleris Date: Wed, 28 Nov 2018 08:16:33 +0000 Subject: base, sim: Add missing destructors Derived classes with virtual functions need to define a virtual destructor or a protected destructor otherwise calling the base class destructor has undefined behavior. This change adds a virtual distructor in the base class. Change-Id: I1c855aa56dff6585ff99b9147bdb4eb9729a0a53 Signed-off-by: Nikos Nikoleris Reviewed-on: https://gem5-review.googlesource.com/c/14815 Reviewed-by: Giacomo Travaglini Reviewed-by: Jason Lowe-Power Maintainer: Jason Lowe-Power --- src/sim/faults.hh | 2 ++ 1 file changed, 2 insertions(+) (limited to 'src/sim') diff --git a/src/sim/faults.hh b/src/sim/faults.hh index be7aab582..747597152 100644 --- a/src/sim/faults.hh +++ b/src/sim/faults.hh @@ -47,6 +47,8 @@ class FaultBase virtual FaultName name() const = 0; virtual void invoke(ThreadContext * tc, const StaticInstPtr &inst = StaticInst::nullStaticInstPtr); + + virtual ~FaultBase() {}; }; class UnimpFault : public FaultBase -- cgit v1.2.3