From da4539dc749c3d29c03de9b3130f1c9a7266be9d Mon Sep 17 00:00:00 2001 From: Andreas Hansson Date: Tue, 9 Sep 2014 04:36:31 -0400 Subject: misc: Fix a number of unitialised variables and members Static analysis unearther a bunch of uninitialised variables and members, and this patch addresses the problem. In all cases these omissions seem benign in the end, but at least fixing them means less false positives next time round. --- src/sim/dvfs_handler.hh | 3 ++- src/sim/eventq.hh | 2 +- src/sim/system.cc | 4 ++-- 3 files changed, 5 insertions(+), 4 deletions(-) (limited to 'src/sim') diff --git a/src/sim/dvfs_handler.hh b/src/sim/dvfs_handler.hh index ba8ed3e8e..c8d962133 100644 --- a/src/sim/dvfs_handler.hh +++ b/src/sim/dvfs_handler.hh @@ -191,7 +191,8 @@ class DVFSHandler : public SimObject * for a future call to change a domain's performance level. */ struct UpdateEvent : public Event { - UpdateEvent() : Event(DVFS_Update_Pri) {} + UpdateEvent() : Event(DVFS_Update_Pri), domainIDToSet(0), + perfLevelToSet(0) {} /** * Static pointer to the single DVFS hander for all the update events diff --git a/src/sim/eventq.hh b/src/sim/eventq.hh index eaefdb2e2..e238785f6 100644 --- a/src/sim/eventq.hh +++ b/src/sim/eventq.hh @@ -287,7 +287,7 @@ class Event : public EventBase, public Serializable * @param queue that the event gets scheduled on */ Event(Priority p = Default_Pri, Flags f = 0) - : nextBin(NULL), nextInBin(NULL), _priority(p), + : nextBin(nullptr), nextInBin(nullptr), _when(0), _priority(p), flags(Initialized | f) { assert(f.noneSet(~PublicWrite)); diff --git a/src/sim/system.cc b/src/sim/system.cc index ffab19c99..cabb358b3 100644 --- a/src/sim/system.cc +++ b/src/sim/system.cc @@ -78,6 +78,8 @@ System::System(Params *p) pagePtr(0), init_param(p->init_param), physProxy(_systemPort, p->cache_line_size), + kernelSymtab(nullptr), + kernel(nullptr), loadAddrMask(p->load_addr_mask), loadAddrOffset(p->load_offset), nextPID(0), @@ -118,8 +120,6 @@ System::System(Params *p) if (params()->kernel == "") { inform("No kernel set for full system simulation. " "Assuming you know what you're doing\n"); - - kernel = NULL; } else { // Get the kernel code kernel = createObjectFile(params()->kernel); -- cgit v1.2.3