From 1cc084fc7a214e6b3ed30910e9cd9a0c81f25b2f Mon Sep 17 00:00:00 2001 From: Gabe Black Date: Thu, 30 Aug 2018 01:39:21 -0700 Subject: systemc: Raise an error when SC_METHOD, etc. is used after starting. Those mechanisms for creating processes are only allowed before the end of elaboration, or in other words before sc_start is called. Technically the check in Accellera's implementation won't trigger if the simulation is stopped, and we immitate that behavior. Change-Id: I9b8b5bd32f876781b6e0d5c0ee0e09de19bdabc1 Reviewed-on: https://gem5-review.googlesource.com/c/12447 Reviewed-by: Gabe Black Maintainer: Gabe Black --- src/systemc/core/sc_module.cc | 29 ++++++++++++++++++++++++++--- 1 file changed, 26 insertions(+), 3 deletions(-) (limited to 'src/systemc/core') diff --git a/src/systemc/core/sc_module.cc b/src/systemc/core/sc_module.cc index bbb9993be..44e442d00 100644 --- a/src/systemc/core/sc_module.cc +++ b/src/systemc/core/sc_module.cc @@ -28,6 +28,7 @@ */ #include +#include #include #include "base/logging.hh" @@ -36,6 +37,7 @@ #include "systemc/core/process_types.hh" #include "systemc/ext/core/sc_module.hh" #include "systemc/ext/core/sc_module_name.hh" +#include "systemc/ext/utils/sc_report_handler.hh" namespace sc_gem5 { @@ -43,7 +45,14 @@ namespace sc_gem5 Process * newMethodProcess(const char *name, ProcessFuncWrapper *func) { - Process *p = new Method(name, func); + Method *p = new Method(name, func); + if (::sc_core::sc_is_running()) { + std::string name = p->name(); + delete p; + SC_REPORT_ERROR("(E541) call to SC_METHOD in sc_module while " + "simulation running", name.c_str()); + return nullptr; + } scheduler.reg(p); return p; } @@ -51,7 +60,14 @@ newMethodProcess(const char *name, ProcessFuncWrapper *func) Process * newThreadProcess(const char *name, ProcessFuncWrapper *func) { - Process *p = new Thread(name, func); + Thread *p = new Thread(name, func); + if (::sc_core::sc_is_running()) { + std::string name = p->name(); + delete p; + SC_REPORT_ERROR("(E542) call to SC_THREAD in sc_module while " + "simulation running", name.c_str()); + return nullptr; + } scheduler.reg(p); return p; } @@ -59,7 +75,14 @@ newThreadProcess(const char *name, ProcessFuncWrapper *func) Process * newCThreadProcess(const char *name, ProcessFuncWrapper *func) { - Process *p = new CThread(name, func); + CThread *p = new CThread(name, func); + if (::sc_core::sc_is_running()) { + std::string name = p->name(); + delete p; + SC_REPORT_ERROR("(E543) call to SC_CTHREAD in sc_module while " + "simulation running", name.c_str()); + return nullptr; + } scheduler.reg(p); p->dontInitialize(); return p; -- cgit v1.2.3