From be014d433860b88e35a4e6cf9e1710c7afab6192 Mon Sep 17 00:00:00 2001 From: Andreas Hansson Date: Mon, 30 May 2016 02:10:48 -0400 Subject: scons: Bump minimum gcc version to 4.8 After reaching consensus on the mailing list, this patch officially makes gcc 4.8 the minimum. A few checks in the SConstruct are cleaned up as a result. This patch also adds "-fno-omit-frame-pointer" when using ASAN (which is part of the gcc/clang recommended flags). --- src/SConscript | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) (limited to 'src') diff --git a/src/SConscript b/src/SConscript index d0835bda3..bb6f26fc1 100755 --- a/src/SConscript +++ b/src/SConscript @@ -1084,9 +1084,9 @@ def makeEnv(env, label, objsfx, strip = False, **kwargs): new_env.Append(LINKFLAGS='-fsanitize=undefined') # The address sanitizer is available for gcc >= 4.8 - if GetOption('with_asan') and \ - compareVersions(env['GCC_VERSION'], '4.8') >= 0: - new_env.Append(CCFLAGS='-fsanitize=address') + if GetOption('with_asan'): + new_env.Append(CCFLAGS=['-fsanitize=address', + '-fno-omit-frame-pointer']) new_env.Append(LINKFLAGS='-fsanitize=address') if env['CLANG']: @@ -1101,7 +1101,8 @@ def makeEnv(env, label, objsfx, strip = False, **kwargs): new_env.Append(LINKFLAGS='-fsanitize=undefined') if GetOption('with_asan'): - new_env.Append(CCFLAGS='-fsanitize=address') + new_env.Append(CCFLAGS=['-fsanitize=address', + '-fno-omit-frame-pointer']) new_env.Append(LINKFLAGS='-fsanitize=address') werror_env = new_env.Clone() -- cgit v1.2.3