Age | Commit message (Collapse) | Author |
|
Fix for bug 697943.
Set the initial replacement font bbox to the empty rectangle for type3 fonts,
and let the type3 glyph loading initialize by taking the union of all glyph
bboxes.
Set the replacement font bbox for non-Type3 fonts to the unit rectangle.
Also remove unused flag from fz_font struct.
|
|
Add an option to the structured text device to preserve images.
If the PDF processor does not have ops to process images, then skip
loading them in the interpreter if possible. If the device does not
have any image callbacks, then don't set the image processing ops in
the run device.
This accomplishes the same effect as the device hints were intended
to do, but without needing to expose them to the PDF interpreter
which may not even have a device since we now have multiple PDF op
processors.
|
|
|
|
We were passing in the wrong source alpha value in one of the
plotter calls. This is not a call used in our standard builds,
hence us not having seen the problem before.
Credit to Sebastian for spotting the problem and suggesting the
fix.
|
|
Should be 0..256 not 0..1
|
|
We call Memento_takeRef etc throughout the code so that each block
keeps a history of the events on which it's reference count changes.
I'd missed a case - fixed here.
|
|
key_storable objects can either be freed 'directly' by an API call
(such as fz_drop_image), or 'internally' by the store realising that
the sole thing holding onto a key_storable is a key.
The current code frees more structure in the direct call than it
does in the internal call. Clearly this is wrong and leads to
leaks.
The fix is to do ALL the freeing in the internal 'drop' function
within the key_storable.
This means we don't need (or want) either fz_drop_key_storable_key or
fz_drop_key_storable to return an int to tell us whether they were
actually dropped, so we make that change to simplify the code.
This shifts the responsibility for freeing the extra internal
structure into the innermost drop functions - fz_drop_image_imp and
fz_drop_image_gprf_imp. To avoid duplicating code, we put the
extra freeing logic into a fz_drop_image_base function.
|
|
|
|
Previously this caused memory checker errors due to
a non-temporary pixmap being accidentally freed and
then later reused as expected.
|
|
Define PATH_MAX in the few files that use it, should it be missing.
|
|
|
|
|
|
TIFF already provides the a/b components prescaled.
Previously the colorspace color conversion process
scaled them again, causing out of range behaviour.
|
|
Previously, if a TIFF file was encoded using CCITT
fax group 3 compression and mixing 1D and 2D codes,
the fax decoder was not instructed to parse the
1D/2D indication bit after EOL. This caused later
issues when parsing the succeeding 1D/2D code,
e.g. resulting in the decoder encountering a
negative 1D code and returning with an error.
Setting k>0 means the 1D/2D indication bit is parsed.
The CCITT fax group 3 specification recommends
setting k based on the vertical resolution. MuPDF's
fax decoder depends only on if k is <0, 0 or >0, not
its value (as recommended by the PDF specification).
Therefore it is not necessary to use the vertical
resolution to determine a particular value for k.
|
|
|
|
It's not used, so prone to bit rot. Better to purge it.
|
|
Replace fz_print_hash with fz_hash_for_each iterator.
Use string formatting callback.
|
|
That's where it's actually being used.
|
|
Don't depend on stdio.h for our own I/O functions.
|
|
|
|
|
|
There is only one implementation, so don't bother with the abstraction.
Just use pdf_function directly.
|
|
|
|
|
|
|
|
PATH_MAX is Linux specific.
|
|
|
|
Don't use FMT_zu macro for fz_throw/fz_warn, since we can portably handle '%zu'
in our own printf formatting.
|
|
|
|
|
|
Decide whether to dash or not in the scan converter, not the
draw-device.
|
|
In all cases we reset the gel before populating it, so pull this
out of the draw device into the population routines.
|
|
In all cases, we sort the gel before scan converting it. So
just roll the sort call into the scan convert call.
|
|
|
|
A document handler normally only exposes a list of extensions and
mimetypes. Only formats that use some kind of extra detection mechnism
need to supply a recognize() callback, such as xps that can handle
.xps-files unpacked into a directory.
|
|
|
|
|
|
I can see no reason for having the reap lock now. We always
hold the ALLOC lock when we need it, so just live with that.
|
|
|
|
As seen with:
mutool draw -o out.ppm Bug697706.epub
|
|
|
|
|
|
More consistent with the rest of the code.
|
|
In keeping with the rest of the code.
|
|
Fits with the rest of the code.
|
|
It seems odd for a document writer to pass a device pointer
out, and then require it to be passed back in.
Hide that in the public API.
|
|
Avoids needing to access the internals of reference counting.
|
|
There is no need to hold a separate flag to say that
we need reaping, when this can be implied from the
store_key_refs and the normal refcount being equal.
In addition, I don't think we were ever actually
setting this, so the code was wrong to start with.
|
|
|
|
This enables people to access (say) a PNG writer without
pulling in every single document writer at link time. (Of
course, currently, without function level linking, even now
we'll pull everything in, but we can improve this by
splitting source files up).
|