From 03611f8dd4b349042e0edc29ea43f84d32f5601c Mon Sep 17 00:00:00 2001 From: Robin Watts Date: Mon, 23 Jan 2012 11:23:01 +0000 Subject: Remove assert in tiling code. Both Zeniko and Malc have said that this causes problems. Following a hint from malc, the following command causes the assert to trigger: win32/Debug/pdfdraw.exe -r0.3 -o out.png ../MyTests/pdf_reference17.pdf 1143 I suspect it's because of the extreme resolution, and the round_rect call. At any rate, disabling the assert is of no real import. --- draw/draw_device.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/draw/draw_device.c b/draw/draw_device.c index 12810420..89169ab6 100644 --- a/draw/draw_device.c +++ b/draw/draw_device.c @@ -1414,9 +1414,11 @@ fz_draw_begin_tile(fz_device *devp, fz_rect area, fz_rect view, float xstep, flo bbox = fz_round_rect(fz_transform_rect(ctm, view)); /* We should never have a bbox that entirely covers our destination. * If we do, then the check for only 1 tile being visible above has - * failed. */ - assert(bbox.x0 > state->dest->x || bbox.x1 < state->dest->x + state->dest->w || - bbox.y0 > state->dest->y || bbox.y1 < state->dest->y + state->dest->h); + * failed. Actually, this *can* fail due to the round_rect, at extreme + * resolutions, so disable this assert. + * assert(bbox.x0 > state->dest->x || bbox.x1 < state->dest->x + state->dest->w || + * bbox.y0 > state->dest->y || bbox.y1 < state->dest->y + state->dest->h); + */ dest = fz_new_pixmap_with_rect(dev->ctx, model, bbox); fz_clear_pixmap(dest); shape = state[0].shape; -- cgit v1.2.3