From d9bc8c6f7fb2e3ec7035bebaaee0edcf59287705 Mon Sep 17 00:00:00 2001 From: Sebastian Rasmussen Date: Mon, 22 Jan 2018 17:56:20 +0100 Subject: Bug 698885: When parsing PDF version, make sure to initialize buffer. Thanks to oss-fuzz for reporting this. --- source/pdf/pdf-xref.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/pdf/pdf-xref.c b/source/pdf/pdf-xref.c index 392adf33..4997ebe5 100644 --- a/source/pdf/pdf-xref.c +++ b/source/pdf/pdf-xref.c @@ -590,7 +590,7 @@ pdf_load_version(fz_context *ctx, pdf_document *doc) fz_seek(ctx, doc->file, 0, SEEK_SET); fz_read_line(ctx, doc->file, buf, sizeof buf); - if (memcmp(buf, "%PDF-", 5) != 0) + if (strlen(buf) < 5 || memcmp(buf, "%PDF-", 5) != 0) fz_throw(ctx, FZ_ERROR_GENERIC, "cannot recognize version marker"); doc->version = 10 * (fz_atof(buf+5) + 0.05f); -- cgit v1.2.3