From c639b84d440cac6dc6e3406fbf647a4bd219ca6f Mon Sep 17 00:00:00 2001
From: Tor Andersson <tor@ghostscript.com>
Date: Thu, 3 Dec 2009 15:36:49 +0100
Subject: Fix possible buffer overflows in the viewer application.

---
 apps/unix/x11pdf.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

(limited to 'apps/unix')

diff --git a/apps/unix/x11pdf.c b/apps/unix/x11pdf.c
index 68c93ac1..20b9d79e 100644
--- a/apps/unix/x11pdf.c
+++ b/apps/unix/x11pdf.c
@@ -428,12 +428,10 @@ void onselreq(Window requestor, Atom selection, Atom target, Atom property, Time
 
 void winopenuri(pdfapp_t *app, char *buf)
 {
-	char cmd[2048];
-	if (getenv("BROWSER"))
-		sprintf(cmd, "$BROWSER %s &", buf);
-	else
-		sprintf(cmd, "open %s", buf);
-	system(cmd);
+	char *browser = getenv("BROWSER");
+	if (!browser)
+		browser = "open";
+	execlp(browser, browser, buf, 0);
 }
 
 static void onkey(int c)
-- 
cgit v1.2.3