From aa35b1b812a53c3653b942ed0e4e89eac9a86bb0 Mon Sep 17 00:00:00 2001 From: Joseph Heenan Date: Thu, 2 Oct 2014 19:57:55 +0200 Subject: iOS: Fix an analyser warning In MuDocRef initialise. it spotted cases where self could be released twice after a failure. --- platform/ios/Classes/MuDocRef.m | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) (limited to 'platform/ios/Classes') diff --git a/platform/ios/Classes/MuDocRef.m b/platform/ios/Classes/MuDocRef.m index 076d633d..bd2b87c0 100644 --- a/platform/ios/Classes/MuDocRef.m +++ b/platform/ios/Classes/MuDocRef.m @@ -30,10 +30,13 @@ } fz_catch(ctx) { - if (doc != NULL) - fz_close_document(doc); - [self release]; - self = nil; + if (self) + { + if (doc != NULL) + fz_close_document(doc); + [self release]; + self = nil; + } } } return self; -- cgit v1.2.3