From 3a24435ce9e22bbda507d1f4862cea0d4391cf96 Mon Sep 17 00:00:00 2001 From: Matt Holgate Date: Thu, 3 Jul 2014 14:44:05 +0100 Subject: Fix memory leak in MuDocRef.m. Remember to release self, if we're returning nil from the initialiser. Also, there is no need for fz_var(doc), because doc is an ivar and effectively equivalent to 'self->doc'. --- platform/ios/Classes/MuDocRef.m | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'platform/ios') diff --git a/platform/ios/Classes/MuDocRef.m b/platform/ios/Classes/MuDocRef.m index db82bbab..076d633d 100644 --- a/platform/ios/Classes/MuDocRef.m +++ b/platform/ios/Classes/MuDocRef.m @@ -12,13 +12,13 @@ dispatch_sync(queue, ^{}); fz_var(self); - fz_var(doc); fz_try(ctx) { doc = fz_open_document(ctx, aFilename); if (!doc) { + [self release]; self = nil; } else @@ -32,6 +32,7 @@ { if (doc != NULL) fz_close_document(doc); + [self release]; self = nil; } } -- cgit v1.2.3